DevTools: Server Timing values should be in milliseconds

third_party/WebKit/Source/devtools/front_end/sdk/ServerTiming.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 SDK.ServerTiming = class {
   /**
    * @param {string} metric
-   * @param {number} value
-   * @param {string} description
+   * @param {?number} value
+   * @param {?string} description
    */
   constructor(metric, value, description) {
     this.metric = metric;
     this.value = value;
     this.description = description;
   }
 
   /**
    * @param {!Array<!SDK.NetworkRequest.NameValue>} headers
    * @return {?Array<!SDK.ServerTiming>}
@@ skipping 10 matching lines @@
     function createFromHeaderValue(valueString) {
       // https://www.w3.org/TR/server-timing/
       var serverTimingMetricRegExp =
           /[ \t]*([\!\#\$\%\&\'\*\+\-\.\^\_\`\|\~0-9A-Za-z]+)[ \t]*(?:=[ \t]*(\d+(?:\.\d+)?))?[ \t]*(?:;[ \t]*(?:"([^"]+)"|([\!\#\$\%\&\'\*\+\-\.\^\_\`\|\~0-9A-Za-z]+)))?[ \t]*(?:,(.*))?/;
       var metricMatch;
       var result = [];
       while (valueString && (metricMatch = serverTimingMetricRegExp.exec(valueString))) {
         var metric = metricMatch[1];
         var value = metricMatch[2];
         var description = metricMatch[3] || metricMatch[4];
-        if (value !== null)
+        if (value !== undefined)
           value = Math.abs(parseFloat(metricMatch[2]));
         valueString = metricMatch[5];  // comma delimited headers
-        result.push(new SDK.ServerTiming(metric, value, description));
+        if (typeof value === 'number' || value === undefined)

[allada, 2017/02/14 00:00:24]

This can send in 'undefined' for value when null and number are only allowed.

Lets do something more like this:

if (typeof value !== 'number' || value === undefined)
  value = null;

This should allow us to obtain a metric of null even if something invalid was
passed for the value. (we'd get a key, but no value)

wdyt?

[caseq, 2017/02/14 00:06:21]

This will be always true due to lines 42 & 43. I guess you may want to check for
NaN.

[paulirish, 2017/02/14 01:25:06]

yup sg. done.

+          result.push(new SDK.ServerTiming(metric, value, description));
       }
       return result;
     }
 
     var serverTimings = rawServerTimingHeaders.reduce((memo, header) => {
       var timing = createFromHeaderValue(header.value);
       Array.prototype.push.apply(memo, timing);
       return memo;
     }, []);
     serverTimings.sort((a, b) => a.metric.toLowerCase().compareTo(b.metric.toLowerCase()));
     return serverTimings;
   }
 };