DevTools: Server Timing values should be in milliseconds

third_party/WebKit/Source/devtools/front_end/network/RequestTimingView.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 255 matching lines @@
      * @param {!SDK.ServerTiming} serverTiming
      * @param {number} right
      */
     function addTiming(serverTiming, right) {
       var colorGenerator = new PerfUI.FlameChart.ColorGenerator({min: 0, max: 360, count: 36}, {min: 50, max: 80}, 80);
       var isTotal = serverTiming.metric.toLowerCase() === 'total';
       var tr = tableElement.createChild('tr', isTotal ? 'network-timing-footer' : '');
       var metric = tr.createChild('td', 'network-timing-metric');
       metric.createTextChild(serverTiming.description || serverTiming.metric);
       var row = tr.createChild('td').createChild('div', 'network-timing-row');
-      var left = scale * (endTime - startTime - serverTiming.value);
-      if (serverTiming.value && left >= 0) {  // don't chart values too big or too small
+
+      if (typeof serverTiming.value !== 'number')

[allada, 2017/02/14 00:00:24]

Can we do this instead?

if (serverTiming.value === null)

[paulirish, 2017/02/14 01:25:06]

yup

+        return;
+      var left = scale * (endTime - startTime - (serverTiming.value / 1000));
+      if (left >= 0) {  // don't chart values too big or too small
         var bar = row.createChild('span', 'network-timing-bar server-timing');
         bar.style.left = left + '%';
         bar.style.right = right + '%';
         bar.textContent = '\u200B';  // Important for 0-time items to have 0 width.
         if (!isTotal)
           bar.style.backgroundColor = colorGenerator.colorForID(serverTiming.metric);
       }
       var label = tr.createChild('td').createChild('div', 'network-timing-bar-title');
-      if (typeof serverTiming.value === 'number')  // a metric timing value is optional
-        label.textContent = Number.secondsToString(serverTiming.value, true);
+      label.textContent = Number.millisToString(serverTiming.value, true);
     }
 
     /**
      * param {string} title
      */
     function createHeader(title) {
       var dataHeader = tableElement.createChild('tr', 'network-timing-table-header');
       dataHeader.createChild('td').createTextChild(title);
       dataHeader.createChild('td').createTextChild('');
       dataHeader.createChild('td').createTextChild(Common.UIString('TIME'));
@@ skipping 48 matching lines @@
 };
 
 Network.RequestTimingView.ConnectionSetupRangeNames = new Set([
   Network.RequestTimeRangeNames.Queueing, Network.RequestTimeRangeNames.Blocking,
   Network.RequestTimeRangeNames.Connecting, Network.RequestTimeRangeNames.DNS, Network.RequestTimeRangeNames.Proxy,
   Network.RequestTimeRangeNames.SSL
 ]);
 
 /** @typedef {{name: !Network.RequestTimeRangeNames, start: number, end: number}} */
 Network.RequestTimeRange;