Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 268983002: Revert of Cast: Fix two video freezing problems (Closed)

Created:
6 years, 7 months ago by hubbe
Modified:
6 years, 7 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Cast: Fix two video freezing problems (https://codereview.chromium.org/252923007/) Reason for revert: Unused variable: http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/66198 Original issue's description: > Cast: Fix two video freezing problems > > 1) The first one only happens when running UDP over localhost: The connect() call > call fails and the sender stops listening to incoming packets. I fixed this by > re-starting the packet listening if needed after each successfully sent packet. > > 2) The second problem is that the packet storage times out packets based on time, > with the assumption that no packet should have to be re-sent if it's older than > the max history time. However, if packets are not ACKed in a timely fashion, the > video_sender may need to re-send arbitrarily old packets. To fix this, I change > the packet storage to remember "max outanding frames" regardless of timing. > > BUG=366911 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268142 TBR=hclam@chromium.org,palmer@chromium.org NOTREECHECKS=true NOTRY=true BUG=366911 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -270 lines) Patch
M chrome/common/cast_messages.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M media/cast/audio_sender/audio_sender.cc View 2 chunks +1 line, -11 lines 0 comments Download
M media/cast/audio_sender/audio_sender_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M media/cast/cast_config.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/cast_config.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 8 chunks +25 lines, -16 lines 0 comments Download
M media/cast/test/sender.cc View 6 chunks +14 lines, -6 lines 0 comments Download
M media/cast/transport/cast_transport_config.h View 2 chunks +12 lines, -11 lines 0 comments Download
M media/cast/transport/cast_transport_config.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M media/cast/transport/cast_transport_sender.h View 2 chunks +3 lines, -2 lines 0 comments Download
M media/cast/transport/cast_transport_sender_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/transport/rtp_sender/packet_storage/packet_storage.h View 2 chunks +11 lines, -25 lines 0 comments Download
M media/cast/transport/rtp_sender/packet_storage/packet_storage.cc View 5 chunks +44 lines, -38 lines 0 comments Download
M media/cast/transport/rtp_sender/packet_storage/packet_storage_unittest.cc View 1 chunk +99 lines, -27 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/transport/rtp_sender/rtp_sender.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_sender.cc View 3 chunks +12 lines, -26 lines 0 comments Download
M media/cast/transport/transport/udp_transport.h View 2 chunks +0 lines, -4 lines 0 comments Download
M media/cast/transport/transport/udp_transport.cc View 5 chunks +4 lines, -23 lines 0 comments Download
M media/cast/transport/transport_audio_sender.cc View 4 chunks +3 lines, -12 lines 0 comments Download
M media/cast/transport/transport_video_sender.cc View 5 chunks +9 lines, -13 lines 0 comments Download
M media/cast/video_sender/external_video_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/video_sender/video_encoder_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/video_sender/video_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/cast/video_sender/video_sender.cc View 7 chunks +7 lines, -25 lines 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hubbe
Created Revert of Cast: Fix two video freezing problems
6 years, 7 months ago (2014-05-05 06:24:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/268983002/1
6 years, 7 months ago (2014-05-05 06:24:28 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 06:26:18 UTC) #3
Message was sent while issue was closed.
Change committed as 268147

Powered by Google App Engine
This is Rietveld 408576698