Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2689803002: Ensure nearby URL count metric is properly initialized (Closed)
Patch Set: npos Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 5aaf095bcbadf0f60c8deb5cb1597140eac99975..8fec24b618a6bb612d9b8afecdad56014c57f307 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -42920,6 +42920,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Omnibox.PhysicalWebProvider.SuggestionUsedWithoutOmniboxFocus"
+ enum="Boolean">
+ <owner>cco3@chromium.org</owner>
+ <owner>mattreynolds@chromium.org</owner>
+ <owner>mmocny@chromium.org</owner>
+ <summary>
+ Records a boolean value indicating whether the Physical Web provider was
+ invoked by focusing the omnibox during the current omnibox session. Recorded
Mark P 2017/02/23 00:38:59 Between the first and second sentence, please add
mattreynolds 2017/02/23 02:03:07 Done.
+ when the user selects an omnibox suggestion. Does not record when the
+ Physical Web omnibox provider is disabled.
+ </summary>
+</histogram>
+
<histogram name="Omnibox.PhysicalWebProviderMatches">
<owner>cco3@chromium.org</owner>
<owner>mattreynolds@chromium.org</owner>
@@ -43072,14 +43085,28 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
-<histogram name="Omnibox.SuggestionUsed.NearbyURLCount" units="URLs">
Mark P 2017/02/23 00:38:59 Please don't delete hold histograms; instead mark
mattreynolds 2017/02/23 02:03:07 Added it back with an <obsolete> block
+<histogram name="Omnibox.SuggestionUsed.NearbyURLCount.AtFocus" units="URLs">
+ <owner>cco3@chromium.org</owner>
+ <owner>mattreynolds@chromium.org</owner>
+ <owner>mmocny@chromium.org</owner>
+ <summary>
+ The number of nearby Physical Web URLs when Physical Web Provider was last
+ focused (i.e., the start of the current session). Recorded when the user
+ accepts an omnibox suggestion, regardless of whether the suggestion came
+ from PhysicalWebProvider. Capped at 50.
+ </summary>
+</histogram>
+
+<histogram name="Omnibox.SuggestionUsed.NearbyURLCount.AtMatchCreation"
+ units="URLs">
<owner>cco3@chromium.org</owner>
<owner>mattreynolds@chromium.org</owner>
<owner>mmocny@chromium.org</owner>
<summary>
- The number of nearby Physical Web URLs when the user focused the omnibox.
- Recorded when the user accepts an omnibox suggestion, regardless of whether
- the suggestion came from PhysicalWebProvider. Capped at 50.
+ The number of nearby Physical Web URLs when Physical Web Provider last
+ constructed matches. Recorded when the user accepts an omnibox suggestion,
+ regardless of whether the suggestion came from PhysicalWebProvider. Capped
+ at 50.
Mark P 2017/02/23 00:38:59 Please add a sentence pointing people to Omnibox.P
mattreynolds 2017/02/23 02:03:07 Done
</summary>
</histogram>

Powered by Google App Engine
This is Rietveld 408576698