Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2689803002: Ensure nearby URL count metric is properly initialized (Closed)
Patch Set: add unit test, AtFocus histogram Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index c17c5e63d071ebcc9caeb8190a071529f5898ff9..6e5247b14a73f31da56a0c79b9b196f8604a0816 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -42836,9 +42836,22 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<owner>mattreynolds@chromium.org</owner>
<owner>mmocny@chromium.org</owner>
<summary>
- The number of nearby Physical Web URLs when the user focused the omnibox.
- Recorded when the user accepts an omnibox suggestion, regardless of whether
- the suggestion came from PhysicalWebProvider. Capped at 50.
+ The number of nearby Physical Web URLs when Physical Web Provider last
+ constructed matches. Recorded when the user accepts an omnibox suggestion,
+ regardless of whether the suggestion came from PhysicalWebProvider. Capped
+ at 50.
Mark P 2017/02/15 06:45:54 nit: either consider renaming this histogram per h
mattreynolds 2017/02/17 03:08:12 Renamed to Omnibox.SuggestionUsed.NearbyURLCount.A
+ </summary>
+</histogram>
+
+<histogram name="Omnibox.SuggestionUsed.NearbyURLCount.AtFocus" units="URLs">
+ <owner>cco3@chromium.org</owner>
+ <owner>mattreynolds@chromium.org</owner>
+ <owner>mmocny@chromium.org</owner>
+ <summary>
+ The number of nearby Physical Web URLs when Physical Web Provider was last
+ focused (i.e., the start of the current session). Recorded when the user
+ accepts an omnibox suggestion, regardless of whether the suggestion came
+ from PhysicalWebProvider. Capped at 50.
</summary>
</histogram>

Powered by Google App Engine
This is Rietveld 408576698