Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2689793002: Track names in DeclarationBuilder. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
index 13cc05d47123654d9516453e423699bc5df114e2..580ddc7e7b0e8faf1d5cbecf0cbd15a06887c59f 100644
--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
@@ -194,7 +194,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginClassDeclaration(Token begin, Token name) {
- library.beginNestedDeclaration();
+ library.beginNestedDeclaration(name.value);
}
@override
@@ -221,7 +221,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginTopLevelMethod(Token token, Token name) {
- library.beginNestedDeclaration(hasMembers: false);
+ library.beginNestedDeclaration(name.value, hasMembers: false);
}
@override
@@ -240,7 +240,7 @@ class OutlineBuilder extends UnhandledListener {
checkEmpty();
library.addProcedure(metadata, modifiers, returnType, name,
typeVariables, formals, asyncModifier, computeProcedureKind(getOrSet),
- beginToken.charOffset);
+ beginToken.charOffset, isTopLevel: true);
}
@override
@@ -257,7 +257,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginMethod(Token token, Token name) {
- library.beginNestedDeclaration(hasMembers: false);
+ library.beginNestedDeclaration(name.value, hasMembers: false);
}
@override
@@ -289,7 +289,7 @@ class OutlineBuilder extends UnhandledListener {
isAbstract: bodyKind == MethodBody.Abstract);
List<MetadataBuilder> metadata = pop();
library.addProcedure(metadata, modifiers, returnType, name, typeVariables,
- formals, asyncModifier, kind, beginToken.charOffset);
+ formals, asyncModifier, kind, beginToken.charOffset, isTopLevel: false);
}
@override
@@ -302,7 +302,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginNamedMixinApplication(Token begin, Token name) {
- library.beginNestedDeclaration(hasMembers: false);
+ library.beginNestedDeclaration(name.value, hasMembers: false);
}
@override
@@ -434,7 +434,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginFunctionTypeAlias(Token token) {
- library.beginNestedDeclaration(hasMembers: false);
+ library.beginNestedDeclaration(null, hasMembers: false);
}
@override

Powered by Google App Engine
This is Rietveld 408576698