Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart

Issue 2689793002: Track names in DeclarationBuilder. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/source/outline_builder.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.kernel_library_builder; 5 library fasta.kernel_library_builder;
6 6
7 import 'package:kernel/ast.dart'; 7 import 'package:kernel/ast.dart';
8 8
9 import 'package:kernel/clone.dart' show 9 import 'package:kernel/clone.dart' show
10 CloneVisitor; 10 CloneVisitor;
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 void addField(List<MetadataBuilder> metadata, 128 void addField(List<MetadataBuilder> metadata,
129 int modifiers, KernelTypeBuilder type, String name, int charOffset) { 129 int modifiers, KernelTypeBuilder type, String name, int charOffset) {
130 addBuilder(name, new KernelFieldBuilder( 130 addBuilder(name, new KernelFieldBuilder(
131 metadata, type, name, modifiers, this, charOffset), charOffset); 131 metadata, type, name, modifiers, this, charOffset), charOffset);
132 } 132 }
133 133
134 void addProcedure(List<MetadataBuilder> metadata, 134 void addProcedure(List<MetadataBuilder> metadata,
135 int modifiers, KernelTypeBuilder returnType, String name, 135 int modifiers, KernelTypeBuilder returnType, String name,
136 List<TypeVariableBuilder> typeVariables, 136 List<TypeVariableBuilder> typeVariables,
137 List<FormalParameterBuilder> formals, AsyncMarker asyncModifier, 137 List<FormalParameterBuilder> formals, AsyncMarker asyncModifier,
138 ProcedureKind kind, int charOffset) { 138 ProcedureKind kind, int charOffset, {bool isTopLevel}) {
139 // Nested declaration began in `OutlineBuilder.beginMethod` or 139 // Nested declaration began in `OutlineBuilder.beginMethod` or
140 // `OutlineBuilder.beginTopLevelMethod`. 140 // `OutlineBuilder.beginTopLevelMethod`.
141 endNestedDeclaration().resolveTypes(typeVariables); 141 endNestedDeclaration().resolveTypes(typeVariables);
142 addBuilder(name, 142 addBuilder(name,
143 new KernelProcedureBuilder(metadata, modifiers, returnType, name, 143 new KernelProcedureBuilder(metadata, modifiers, returnType, name,
144 typeVariables, formals, asyncModifier, kind, this, charOffset), 144 typeVariables, formals, asyncModifier, kind, this, charOffset),
145 charOffset); 145 charOffset);
146 } 146 }
147 147
148 void addFactoryMethod(List<MetadataBuilder> metadata, 148 void addFactoryMethod(List<MetadataBuilder> metadata,
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 } 281 }
282 expression.value = 282 expression.value =
283 defaultArgumentFrom(names[expression.name].initializer) 283 defaultArgumentFrom(names[expression.name].initializer)
284 ..parent = expression; 284 ..parent = expression;
285 } 285 }
286 } 286 }
287 } 287 }
288 return argumentsWithMissingDefaultValues.length; 288 return argumentsWithMissingDefaultValues.length;
289 } 289 }
290 } 290 }
OLDNEW
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/source/outline_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698