Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 2689713003: Don't clear 'web animations dirty' flag if we have no rare data (Closed)
Patch Set: Use testharness Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann
3 * <zimmermann@kde.org> 3 * <zimmermann@kde.org>
4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 4 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 6 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 EffectStack::activeInterpolations( 236 EffectStack::activeInterpolations(
237 &elementAnimations()->effectStack(), nullptr, nullptr, 237 &elementAnimations()->effectStack(), nullptr, nullptr,
238 KeyframeEffectReadOnly::DefaultPriority, isSVGAttributeHandle); 238 KeyframeEffectReadOnly::DefaultPriority, isSVGAttributeHandle);
239 for (auto& entry : activeInterpolationsMap) { 239 for (auto& entry : activeInterpolationsMap) {
240 const QualifiedName& attribute = entry.key.svgAttribute(); 240 const QualifiedName& attribute = entry.key.svgAttribute();
241 SVGInterpolationTypesMap map; 241 SVGInterpolationTypesMap map;
242 InterpolationEnvironment environment( 242 InterpolationEnvironment environment(
243 map, *this, propertyFromAttribute(attribute)->baseValueBase()); 243 map, *this, propertyFromAttribute(attribute)->baseValueBase());
244 InvalidatableInterpolation::applyStack(entry.value, environment); 244 InvalidatableInterpolation::applyStack(entry.value, environment);
245 } 245 }
246 if (!hasSVGRareData())
247 return;
246 svgRareData()->setWebAnimatedAttributesDirty(false); 248 svgRareData()->setWebAnimatedAttributesDirty(false);
247 } 249 }
248 250
249 static inline void notifyAnimValChanged(SVGElement* targetElement, 251 static inline void notifyAnimValChanged(SVGElement* targetElement,
250 const QualifiedName& attributeName) { 252 const QualifiedName& attributeName) {
251 targetElement->invalidateSVGAttributes(); 253 targetElement->invalidateSVGAttributes();
252 targetElement->svgAttributeChanged(attributeName); 254 targetElement->svgAttributeChanged(attributeName);
253 } 255 }
254 256
255 template <typename T> 257 template <typename T>
(...skipping 1044 matching lines...) Expand 10 before | Expand all | Expand 10 after
1300 visitor->trace(m_className); 1302 visitor->trace(m_className);
1301 Element::trace(visitor); 1303 Element::trace(visitor);
1302 } 1304 }
1303 1305
1304 const AtomicString& SVGElement::eventParameterName() { 1306 const AtomicString& SVGElement::eventParameterName() {
1305 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt")); 1307 DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt"));
1306 return evtString; 1308 return evtString;
1307 } 1309 }
1308 1310
1309 } // namespace blink 1311 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698