third_party/WebKit/LayoutTests/svg/animations/animval-web-animations-flush-crash.html - Issue 2689713003: Don't clear 'web animations dirty' flag if we have no rare data

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/animations/animval-web-animations-flush-crash.html

Issue 2689713003: Don't clear 'web animations dirty' flag if we have no rare data (Closed)

Patch Set: Don't compute style for node that isn't in the document Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 @keyframes anim { 0% { opacity: 0; } }

	4 * { animation-name: anim; animation-duration: 4s; }

	5 </style>

	6 <p>PASS if no crash</p>

	7 <script>

	8 if (window.testRunner) {

	9 testRunner.dumpAsText();

	10 testRunner.waitUntilDone();

	11 }

	12 onload = function() {

	13 let parent = document.createElement("div");

	14 element = parent.appendChild(

	15 document.createElementNS("http://www.w3.org/2000/svg", "marker "));

	16

	17 setTimeout(function() {

	18 element.computedName;
	fs 2017/02/13 19:16:07 This would trigger the DCHECK in Node::containingT This would trigger the DCHECK in Node::containingTreeScope, fixed by the change to AXObject.cpp. With that fix, the crash does happen though, making the test mostly useless. Any idea if the same thing (resolving a style without attaching it to a node I'm assuming is the thing) could be triggered in some other way?
	19 let before = performance.now();

	20 while (performance.now() - before < 17)

	21 ;
	alancutter (OOO until 2018) 2017/02/15 04:11:45 I wonder if internals.pauseAnimations(document.tim I wonder if internals.pauseAnimations(document.timeline.currentTime + 100) would work instead of a busy wait. fs 2017/02/15 14:18:30 Sadly, no =(. (Probably because of the lifecycle u Show quoted text On 2017/02/15 at 04:11:45, alancutter wrote: > I wonder if internals.pauseAnimations(document.timeline.currentTime + 100) would work instead of a busy wait. Sadly, no =(. (Probably because of the lifecycle update in that method.)
	22 element.className.animVal;

	23 if (window.testRunner)

	24 testRunner.notifyDone();

	25 });

	26 };

	27 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/animations/animval-web-animations-flush-crash-expected.txt » ('j') | no next file with comments »