Add intellij metadata to the repo.

Add intellij metadata to the repo.

BUG=
R=pquitslund@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/86a235e2195fd720c835cf840f1171f909db5644

[devoncarew, 2017-02-10 18:22:59]

devoncarew@google.com changed reviewers:
+ pquitslund@google.com, scheglov@google.com

[devoncarew, 2017-02-10 18:23:00]

Add intellij metadata to the repo; this will make it easier to work on the sdk
code with IntelliJ.

[pquitslund, 2017-02-10 18:38:06]

lgtm

[scheglov, 2017-02-10 20:30:34]

lgtm

[devoncarew, 2017-02-10 20:47:11]

Description was changed from

==========
Add intellij metadata to the repo.

BUG=
==========

to

==========
Add intellij metadata to the repo.

BUG=
R=pquitslund@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/86a235e2195fd720c835cf840f1171f909db5644
==========

[devoncarew, 2017-02-10 20:47:12]

Committed patchset #1 (id:1) manually as
86a235e2195fd720c835cf840f1171f909db5644 (presubmit successful).

[Brian Wilkerson, 2017-02-11 21:09:42]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-02-11 21:09:42]

https://codereview.chromium.org/2689673003/diff/1/pkg/analysis_server/analysi...
File pkg/analysis_server/analysis_server.iml (right):

https://codereview.chromium.org/2689673003/diff/1/pkg/analysis_server/analysi...
pkg/analysis_server/analysis_server.iml:7: <excludeFolder
url="file://$MODULE_DIR$/benchmark/integration/packages" />
I don't understand this. There shouldn't be any 'packages' directories anywhere
in a checkout of any dart-lang repository, so it seems pointless, and probably
wasteful to mark them as being excluded. (I believe that IntelliJ currently
sends all of the exclusions to server, which then has to check each of them
every time it walks the directory structure and every time a file is added.)

If you have 'packages' directories on your system, please remove them, then
consider removing these exclusions from the metadata.

https://codereview.chromium.org/2689673003/diff/1/pkg/analyzer_cli/.gitignore
File pkg/analyzer_cli/.gitignore (left):

https://codereview.chromium.org/2689673003/diff/1/pkg/analyzer_cli/.gitignore...
pkg/analyzer_cli/.gitignore:1: .buildlog
I thought we decided that we could remove all .gitignore files.

[devoncarew, 2017-02-12 02:42:06]

https://codereview.chromium.org/2689673003/diff/1/pkg/analysis_server/analysi...
File pkg/analysis_server/analysis_server.iml (right):

https://codereview.chromium.org/2689673003/diff/1/pkg/analysis_server/analysi...
pkg/analysis_server/analysis_server.iml:7: <excludeFolder
url="file://$MODULE_DIR$/benchmark/integration/packages" />
On 2017/02/11 21:09:42, Brian Wilkerson wrote:
> I don't understand this. There shouldn't be any 'packages' directories
anywhere
> in a checkout of any dart-lang repository, so it seems pointless, and probably
> wasteful to mark them as being excluded. (I believe that IntelliJ currently
> sends all of the exclusions to server, which then has to check each of them
> every time it walks the directory structure and every time a file is added.)
> 
> If you have 'packages' directories on your system, please remove them, then
> consider removing these exclusions from the metadata.

This is the IntelliJ metadata file - these excludes are part of what it ignores,
not the analysis server.

From talking with Alex, this file can get much simpler as soon as the lowest
supported version of the SDK is one that no longer supports 'packages' symlinks.

But to reiterate, these exclusions are not related to the analysis server, or to
any packages symlinks on disk.

https://codereview.chromium.org/2689673003/diff/1/pkg/analyzer_cli/.gitignore
File pkg/analyzer_cli/.gitignore (left):

https://codereview.chromium.org/2689673003/diff/1/pkg/analyzer_cli/.gitignore...
pkg/analyzer_cli/.gitignore:1: .buildlog
On 2017/02/11 21:09:42, Brian Wilkerson wrote:
> I thought we decided that we could remove all .gitignore files.

Happy to have this one deleted.

[mallerywhitworth, 2017-02-12 06:54:30]

mallerywhitworth@gmail.com changed reviewers:
+ mallerywhitworth@gmail.com

[mallerywhitworth, 2017-02-12 06:54:31]

lgtm

[mallerywhitworth, 2017-02-12 06:54:31]

lgtm

lgtm

[mallerywhitworth, 2017-02-12 06:54:34]

lgtm

lgtm