Inline base::BinaryValue into base::Value

chromecast/base/serializers_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <vector>
+
 #include "base/files/file_util.h"
 #include "base/values.h"
 #include "chromecast/base/scoped_temp_file.h"
 #include "chromecast/base/serializers.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromecast {
 namespace {
 const char kEmptyJsonString[] = "{}";
 const char kEmptyJsonFileString[] = "{\n\n}\n";
@@ skipping 31 matching lines @@
   EXPECT_NE(nullptr, value.get());
 }
 
 TEST(DeserializeFromJson, PoorlyFormedJsonObject) {
   std::string str = kPoorlyFormedJsonString;
   std::unique_ptr<base::Value> value = DeserializeFromJson(str);
   EXPECT_EQ(nullptr, value.get());
 }
 
 TEST(SerializeToJson, BadValue) {
-  base::BinaryValue value(std::unique_ptr<char[]>(new char[12]), 12);
+  base::BinaryValue value(std::vector<char>(12));
   std::unique_ptr<std::string> str = SerializeToJson(value);
   EXPECT_EQ(nullptr, str.get());
 }
 
 TEST(SerializeToJson, EmptyValue) {
   base::DictionaryValue value;
   std::unique_ptr<std::string> str = SerializeToJson(value);
   ASSERT_NE(nullptr, str.get());
   EXPECT_EQ(kEmptyJsonString, *str);
 }
@@ skipping 42 matching lines @@
   ScopedTempFile temp;
   EXPECT_EQ(static_cast<int>(strlen(kPoorlyFormedJsonString)),
             temp.Write(kPoorlyFormedJsonString));
   std::unique_ptr<base::Value> value = DeserializeJsonFromFile(temp.path());
   EXPECT_EQ(nullptr, value.get());
 }
 
 TEST(SerializeJsonToFile, BadValue) {
   ScopedTempFile temp;
 
-  base::BinaryValue value(std::unique_ptr<char[]>(new char[12]), 12);
+  base::BinaryValue value(std::vector<char>(12));
   ASSERT_FALSE(SerializeJsonToFile(temp.path(), value));
   std::string str(temp.Read());
   EXPECT_TRUE(str.empty());
 }
 
 TEST(SerializeJsonToFile, EmptyValue) {
   ScopedTempFile temp;
 
   base::DictionaryValue value;
   ASSERT_TRUE(SerializeJsonToFile(temp.path(), value));
@@ skipping 10 matching lines @@
   ASSERT_TRUE(SerializeJsonToFile(temp.path(), orig_value));
   std::string str(temp.Read());
   ASSERT_FALSE(str.empty());
 
   std::unique_ptr<base::Value> new_value = DeserializeJsonFromFile(temp.path());
   ASSERT_NE(nullptr, new_value.get());
   EXPECT_TRUE(new_value->Equals(&orig_value));
 }
 
 }  // namespace chromecast