PlzNavigate: Enforce 'form-action' CSP on the browser-side.

content/browser/frame_host/navigation_handle_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
 
 #include "content/public/browser/navigation_handle.h"
 
 #include <stddef.h>
@@ skipping 75 matching lines @@
   // associated with this navigation.
   static std::unique_ptr<NavigationHandleImpl> Create(
       const GURL& url,
       const std::vector<GURL>& redirect_chain,
       FrameTreeNode* frame_tree_node,
       bool is_renderer_initiated,
       bool is_same_page,
       const base::TimeTicks& navigation_start,
       int pending_nav_entry_id,
       bool started_from_context_menu,
-      bool should_bypass_main_world_csp);
+      bool should_bypass_main_world_csp,
+      bool is_form_submission);
   ~NavigationHandleImpl() override;
 
   // NavigationHandle implementation:
   const GURL& GetURL() override;
   SiteInstance* GetStartingSiteInstance() override;
   bool IsInMainFrame() override;
   bool IsParentMainFrame() override;
   bool IsRendererInitiated() override;
   bool WasServerRedirect() override;
   const std::vector<GURL>& GetRedirectChain() override;
@@ skipping 38 matching lines @@
   void CallDidCommitNavigationForTesting(const GURL& url) override;
   bool WasStartedFromContextMenu() const override;
   const GURL& GetSearchableFormURL() override;
   const std::string& GetSearchableFormEncoding() override;
   ReloadType GetReloadType() override;
   RestoreType GetRestoreType() override;
   const GlobalRequestID& GetGlobalRequestID() override;
 
   NavigationData* GetNavigationData() override;
 
+  // Whether or not the navigation has been initiated by a form submission. It
+  // is currently not available when PlzNavigate is disabled.

[alexmos, 2017/02/28 02:48:47]

I'll defer to clamy@ and nasko@ on whether this is ok to land with a DCHECK
without PlzNavigate.  Presumably, we could plumb this information without
PlzNavigate as well - is that in your plans?  If so, could you add a TODO?  

[arthursonzogni, 2017/03/07 16:25:51]

Yes, my plan was to eventually plumb this information without PlzNavigate as
well if we really need it. But I think that the old navigation architecture will
be removed before we might need it.
So, I think that no TODO is required here.

[nasko, 2017/03/09 05:35:17]

Adding a TODO and keeping it PlzNavigate specific is fine with me.

[arthursonzogni, 2017/03/10 09:35:37]

Okay, but please notice that I will have to remove
  DCHECK(IsBrowserSideNavigationEnabled())
      << "This method is implemented only with PlzNavigate";

Done.

+  bool is_form_submission() const;

[nasko, 2017/03/09 05:35:17]

Since this is a simple accessor, it should be inlined in the header.

[arthursonzogni, 2017/03/10 09:35:37]

Done.

+
   // The NavigatorDelegate to notify/query for various navigation events.
   // Normally this is the WebContents, except if this NavigationHandle was
   // created during a navigation to an interstitial page. In this case it will
   // be the InterstitialPage itself.
   //
   // Note: due to the interstitial navigation case, all calls that can possibly
   // expose the NavigationHandle to code outside of content/ MUST go though the
   // NavigatorDelegate. In particular, the ContentBrowserClient should not be
   // called directly form the NavigationHandle code. Thus, these calls will not
   // expose the NavigationHandle when navigating to an InterstialPage.
@@ skipping 187 matching lines @@
   };
 
   NavigationHandleImpl(const GURL& url,
                        const std::vector<GURL>& redirect_chain,
                        FrameTreeNode* frame_tree_node,
                        bool is_renderer_initiated,
                        bool is_same_page,
                        const base::TimeTicks& navigation_start,
                        int pending_nav_entry_id,
                        bool started_from_context_menu,
-                       bool should_bypass_main_world_csp);
+                       bool should_bypass_main_world_csp,
+                       bool is_form_submission);
 
   NavigationThrottle::ThrottleCheckResult CheckWillStartRequest();
   NavigationThrottle::ThrottleCheckResult CheckWillRedirectRequest();
   NavigationThrottle::ThrottleCheckResult CheckWillProcessResponse();
 
   // Called when WillProcessResponse checks are done, to find the final
   // RenderFrameHost for the navigation. Checks whether the navigation should be
   // transferred. Returns false if the transfer attempt results in the
   // destruction of this NavigationHandle and the navigation should no longer
   // proceed. This can happen when the RenderFrameHostManager determines a
@@ skipping 131 matching lines @@
   GURL previous_url_;
   GURL base_url_;
   net::HostPortPair socket_address_;
   NavigationType navigation_type_;
 
   // Whether or not the navigation has been issued by an isolated world, for
   // instance from a chrome extension. When true, the navigation should not be
   // blocked by the parent frame's CSP.
   bool should_bypass_main_world_csp_;
 
+  // Whether or not the navigation results from the submission of a form.
+  bool is_form_submission_;
+
   base::WeakPtrFactory<NavigationHandleImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_