Issue 268963002: Allow the PDF extension to be run in incognito mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268963002: Allow the PDF extension to be run in incognito mode. (Closed)

Created:
6 years, 7 months ago by raymes

Modified:
6 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Allow the PDF extension to be run in incognito mode. This allows PDF to be run in incognito mode but changing the incognito manifest key to "split". This causes a new process to be loaded for the extension in incognito. This is a requirement for doing top level navigations to an extension in incognito mode as per https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser/extension_protocols.cc&rcl=1399166280&l=287 BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268308

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/resources/pdf/manifest.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/268963002/1

6 years, 7 months ago (2014-05-05 19:47:05 UTC) #3

Message was sent while issue was closed.

Change committed as 268308