Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: runtime/vm/debugger.h

Issue 2689623002: Delete Breakpoint objects, fixing memory leak (Closed)
Patch Set: wip Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.h
diff --git a/runtime/vm/debugger.h b/runtime/vm/debugger.h
index 7bd5d2878a3088daece976aee7f7ece8ce24e046..20af85cbdaf8f17a0d80a5a5b60eb7de81626f03 100644
--- a/runtime/vm/debugger.h
+++ b/runtime/vm/debugger.h
@@ -204,7 +204,6 @@ class CodeBreakpoint {
RawFunction* function() const;
uword pc() const { return pc_; }
TokenPosition token_pos() const { return token_pos_; }
- bool IsInternal() const { return bpt_location_ == NULL; }
RawScript* SourceCode();
RawString* SourceUrl();
@@ -611,7 +610,7 @@ class Debugger {
TokenPosition last_token_pos,
intptr_t requested_line,
intptr_t requested_column);
- void RemoveInternalBreakpoints();
+ void RemoveUnlinkedCodeBreakpoints();
void UnlinkCodeBreakpoints(BreakpointLocation* bpt_location);
BreakpointLocation* GetLatentBreakpoint(const String& url,
intptr_t line,
@@ -726,6 +725,8 @@ class Debugger {
// breakpoint.
bool skip_next_step_;
+ bool needs_breakpoint_cleanup_;
+
// We keep this breakpoint alive until after the debugger does the step over
// async continuation machinery so that we can report that we've stopped
// at the breakpoint.
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698