Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2689623002: Delete Breakpoint objects, fixing memory leak (Closed)

Created:
3 years, 10 months ago by hausner
Modified:
3 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Delete Breakpoint objects, fixing memory leak Delete Breakpoint objects from the C heap when they are no longer needed. Also delete inactive code breakpoint objects more aggressively. This should fix the memory leaks reported in #28348. General cleanup of breakpoint handling code and comments. BUG=#28348 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/74da383d6fb62288f50f37bf631780e589831d5e

Patch Set 1 #

Patch Set 2 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -41 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/debugger.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 8 chunks +51 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
3 years, 10 months ago (2017-02-09 22:48:36 UTC) #3
rmacnak
lgtm
3 years, 10 months ago (2017-02-09 23:37:00 UTC) #4
hausner
3 years, 10 months ago (2017-02-10 18:43:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
74da383d6fb62288f50f37bf631780e589831d5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698