Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: third_party/WebKit/Source/modules/vr/VRDisplay.h

Issue 2689563008: Fix WebVR does not properly stop presenting if requestPresent rejects. (Closed)
Patch Set: address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/vr/VRDisplay.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef VRDisplay_h 5 #ifndef VRDisplay_h
6 #define VRDisplay_h 6 #define VRDisplay_h
7 7
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/dom/FrameRequestCallback.h" 9 #include "core/dom/FrameRequestCallback.h"
10 #include "core/events/EventTarget.h" 10 #include "core/events/EventTarget.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 115
116 VRController* controller(); 116 VRController* controller();
117 117
118 private: 118 private:
119 void onFullscreenCheck(TimerBase*); 119 void onFullscreenCheck(TimerBase*);
120 void onPresentComplete(bool); 120 void onPresentComplete(bool);
121 121
122 void onConnected(); 122 void onConnected();
123 void onDisconnected(); 123 void onDisconnected();
124 124
125 void stopPresenting();
126
125 void OnPresentChange(); 127 void OnPresentChange();
126 128
127 // VRDisplayClient 129 // VRDisplayClient
128 void OnChanged(device::mojom::blink::VRDisplayInfoPtr) override; 130 void OnChanged(device::mojom::blink::VRDisplayInfoPtr) override;
129 void OnExitPresent() override; 131 void OnExitPresent() override;
130 void OnBlur() override; 132 void OnBlur() override;
131 void OnFocus() override; 133 void OnFocus() override;
132 void OnActivate(device::mojom::blink::VRDisplayEventReason) override; 134 void OnActivate(device::mojom::blink::VRDisplayEventReason) override;
133 void OnDeactivate(device::mojom::blink::VRDisplayEventReason) override; 135 void OnDeactivate(device::mojom::blink::VRDisplayEventReason) override;
134 136
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 RequestDenied = 12, 202 RequestDenied = 12,
201 FullscreenNotEnabled = 13, 203 FullscreenNotEnabled = 13,
202 PresentationResultMax, // Must be last member of enum. 204 PresentationResultMax, // Must be last member of enum.
203 }; 205 };
204 206
205 void ReportPresentationResult(PresentationResult); 207 void ReportPresentationResult(PresentationResult);
206 208
207 } // namespace blink 209 } // namespace blink
208 210
209 #endif // VRDisplay_h 211 #endif // VRDisplay_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/vr/VRDisplay.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698