Fasta: Change BodyBuilder.buildCompileTimeError to throw an instance of _CompileTimeError.

Fasta: Change BodyBuilder.buildCompileTimeError to throw an instance of _CompileTimeError.

This is a VM specific class that is recognized by exception handling code in VM.

Using this class instead of string guarantees that VM terminates with the correct exit code: kCompilationErrorExitCode (254) and not kErrorExitCode (255).

BUG=
R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/5e09ca8d97c2b433c8ae45fcdcdcd11bd58ef3e3

[Vyacheslav Egorov (Google), 2017-02-09 15:55:23]

vegorov@google.com changed reviewers:
+ ahe@google.com

[Vyacheslav Egorov (Google), 2017-02-09 15:55:23]

PTAL

With this we pass 300 tests more in -c dartk --use-fasta configuration (from
~1000 more failing tests to ~700 more failing tests)

[ahe, 2017-02-09 16:03:21]

lgtm

Thank you!

https://codereview.chromium.org/2689543002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2689543002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:2189: final Constructor
constructor = coreTypes.getCoreClass(
Could you add:

// TODO(ahe): Use a method on TargetImplementation for looking up the
constructor.

[Vyacheslav Egorov (Google), 2017-02-09 16:13:51]

Description was changed from

==========
Fasta: Change BodyBuilder.buildCompileTimeError to throw an instance of
_CompileTimeError.

This is a VM specific class that is recognized by exception handling code in VM.

Using this class instead of string guarantees that VM terminates with the
correct exit code: kCompilationErrorExitCode (254) and not kErrorExitCode (255).

BUG=
==========

to

==========
Fasta: Change BodyBuilder.buildCompileTimeError to throw an instance of
_CompileTimeError.

This is a VM specific class that is recognized by exception handling code in VM.

Using this class instead of string guarantees that VM terminates with the
correct exit code: kCompilationErrorExitCode (254) and not kErrorExitCode (255).

BUG=
R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5e09ca8d97c2b433c8ae45fcdcdcd11bd58ef3e3
==========

[Vyacheslav Egorov (Google), 2017-02-09 16:13:52]

Committed patchset #2 (id:20001) manually as
5e09ca8d97c2b433c8ae45fcdcdcd11bd58ef3e3 (presubmit successful).