Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: test/ios/gyptest-per-config-settings.py

Issue 26895006: ninja/mac: Support iOS codesign for ninja builds. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/ios/app-bundle/test-device.gyp ('K') | « test/ios/app-bundle/test-device.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ios/gyptest-per-config-settings.py
===================================================================
--- test/ios/gyptest-per-config-settings.py (revision 1754)
+++ test/ios/gyptest-per-config-settings.py (working copy)
@@ -22,6 +22,13 @@
print 'File: Expected %s, got %s' % (expected, o)
test.fail_test()
+def CheckSignature(file):
+ proc = subprocess.Popen(['codesign', '-v', file], stdout=subprocess.PIPE)
+ o = proc.communicate()[0].strip()
+ assert not proc.returncode
+ if "code object is not signed at all" in o:
+ print 'File %s not properly signed.' % (file)
+ test.fail_test()
def CheckPlistvalue(plist, key, expected):
if key not in plist:
@@ -68,6 +75,7 @@
if configuration == 'Default-iphoneos':
CheckFileType(result_file, 'armv7')
CheckPlistvalue(plist, 'CFBundleSupportedPlatforms', ['iPhoneOS'])
+ CheckSignature(result_file)
else:
CheckFileType(result_file, 'i386')
CheckPlistvalue(plist, 'CFBundleSupportedPlatforms', ['iPhoneSimulator'])
« test/ios/app-bundle/test-device.gyp ('K') | « test/ios/app-bundle/test-device.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698