Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: pylib/gyp/generator/ninja.py

Issue 26895006: ninja/mac: Support iOS codesign for ninja builds. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pylib/gyp/xcode_emulation.py » ('j') | pylib/gyp/xcode_emulation.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/ninja.py
===================================================================
--- pylib/gyp/generator/ninja.py (revision 1754)
+++ pylib/gyp/generator/ninja.py (working copy)
@@ -1214,6 +1214,14 @@
quiet=True)
postbuilds = gyp.xcode_emulation.GetSpecPostbuildCommands(spec, quiet=True)
postbuilds = target_postbuilds + postbuilds
+ if self.target.type == "executable" and output_binary is not None:
Nico 2013/10/14 16:54:55 Does codesigning run before or after explicit "pos
justincohen 2013/10/14 16:59:12 It runs after -- very last step. On 2013/10/14 16
Nico 2013/10/14 17:02:24 Hm, that's annoying :-/ Maybe we should change th
+ postbuilds = self.xcode_settings.GetIOSPostbuilds(
+ self.config_name,
+ QuoteShellArgument(
+ os.path.normpath(os.path.join(self.base_to_build, output_binary)),
+ self.flavor),
+ postbuilds)
+
if not postbuilds:
return ''
# Postbuilds expect to be run in the gyp file's directory, so insert an
« no previous file with comments | « no previous file | pylib/gyp/xcode_emulation.py » ('j') | pylib/gyp/xcode_emulation.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698