ninja/mac: Support iOS codesign for ninja builds.

pylib/gyp/xcode_emulation.py

 # Copyright (c) 2012 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This module contains classes that help to emulate xcodebuild behavior on top of
 other build systems, such as make and ninja.
 """
 
 import copy
 import gyp.common
 import os.path
 import re
 import shlex
 import subprocess
 import sys
 from gyp.common import GypError
 
 class XcodeSettings(object):
   """A class that understands the gyp 'xcode_settings' object."""
 
   # Populated lazily by _SdkPath(). Shared by all XcodeSettings, so cached
   # at class-level for efficiency.
   _sdk_path_cache = {}
 
   # Populated lazily by GetExtraPlistItems(). Shared by all XcodeSettings, so
   # cached at class-level for efficiency.
   _plist_cache = {}
 
+  # Populated lazily by GetIOSPostbuilds.  Shared by all XcodeSettings, so
+  # cached at class-level for efficiency.
+  _codesigning_key_cache = {}
+
   def __init__(self, spec):
     self.spec = spec
 
     self.isIOS = False
 
     # Per-target 'xcode_settings' are pushed down into configs earlier by gyp.
     # This means self.xcode_settings[config] always contains all settings
     # for that config -- the per-target settings as well. Settings that are
     # the same for all configs are implicitly per-target settings.
     self.xcode_settings = {}
     configs = spec['configurations']
     for configname, config in configs.iteritems():
       self.xcode_settings[configname] = config.get('xcode_settings', {})
       if self.xcode_settings[configname].get('IPHONEOS_DEPLOYMENT_TARGET',
                                              None):
         self.isIOS = True
 
-      # If you need this, speak up at http://crbug.com/122592
-      conditional_keys = [key for key in self.xcode_settings[configname]
-                          if key.endswith(']')]
-      if conditional_keys:
-        print 'Warning: Conditional keys not implemented, ignoring:', \
-              ' '.join(conditional_keys)
-        for key in conditional_keys:
-          del self.xcode_settings[configname][key]
+      if self.isIOS:
+        self._ConvertConditionalKeys(configname)
+      else:

[Nico, 2013/10/14 16:54:55]

Why else?

[justincohen, 2013/10/14 16:59:12]

I wasn't sure what to do here.  I thought it would be safe to leave the warning
for non-iOS builds.

On 2013/10/14 16:54:55, Nico wrote:

[Nico, 2013/10/14 17:00:07]

Sure, but shouldn't you have it for ios builds too?

[justincohen, 2013/10/14 17:01:49]

I'll change it not warn for ios/sdk=iphoneos*, but warn for everything else.


On 2013/10/14 17:00:07, Nico wrote:

+        # If you need this, speak up at http://crbug.com/122592
+        conditional_keys = [key for key in self.xcode_settings[configname]
+                            if key.endswith(']')]
+        if conditional_keys:
+          print 'Warning: Conditional keys not implemented, ignoring:', \
+                ' '.join(conditional_keys)
+          for key in conditional_keys:
+            del self.xcode_settings[configname][key]
 
     # This is only non-None temporarily during the execution of some methods.
     self.configname = None
 
     # Used by _AdjustLibrary to match .a and .dylib entries in libraries.
     self.library_re = re.compile(r'^lib([^/]+)\.(a|dylib)$')
 
+  def _ConvertConditionalKeys(self, configname):
+    settings = self.xcode_settings[configname]
+    conditional_keys = [key for key in settings if key.endswith(']')]
+    for key in conditional_keys:
+        if key.endswith("[sdk=iphoneos*]") and configname.endswith("iphoneos"):
+          new_key = key.split("[")[0]
+          settings[new_key] = settings[key]
+        del settings[key]
+
   def _Settings(self):
     assert self.configname
     return self.xcode_settings[self.configname]
 
   def _Test(self, test_key, cond_key, default):
     return self._Settings().get(test_key, default) == cond_key
 
   def _Appendf(self, lst, test_key, format_str, default=None):
     if test_key in self._Settings():
       lst.append(format_str % str(self._Settings()[test_key]))
@@ skipping 673 matching lines @@
     return result
 
   def GetTargetPostbuilds(self, configname, output, output_binary, quiet=False):
     """Returns a list of shell commands that contain the shell commands
     to run as postbuilds for this target, before the actual postbuilds."""
     # dSYMs need to build before stripping happens.
     return (
         self._GetDebugInfoPostbuilds(configname, output, output_binary, quiet) +
         self._GetStripPostbuilds(configname, output_binary, quiet))
 
+  def GetIOSPostbuilds(self, configname, output_binary, postbuilds):
+    if self.isIOS:
+      self.configname = configname
+      identity = self._Settings().get('CODE_SIGN_IDENTITY')
+      if identity == None:
+        return postbuilds
+
+      if identity not in XcodeSettings._codesigning_key_cache:
+        proc = subprocess.Popen(['security', 'find-identity', '-p',
+                                 'codesigning', '-v'], stdout=subprocess.PIPE)
+        output = proc.communicate()[0].strip()
+        key_id = None
+        for item in output.split("\n"):
+          if identity in item:
+            assert key_id == None, (
+                "Multiple codesigning identities for identity: %s" %
+                identity)
+            key = item.split(' ')[1]
+        XcodeSettings._codesigning_key_cache[identity] = key
+      postbuilds.append(
+        "/usr/bin/codesign -v --force --sign %s %s" %
+        (XcodeSettings._codesigning_key_cache[identity], output_binary))
+    return postbuilds
+
   def _AdjustLibrary(self, library, config_name=None):
     if library.endswith('.framework'):
       l = '-framework ' + os.path.splitext(os.path.basename(library))[0]
     else:
       m = self.library_re.match(library)
       if m:
         l = '-l' + m.group(1)
       else:
         l = library
     return l.replace('$(SDKROOT)', self._SdkPath(config_name))
@@ skipping 462 matching lines @@
         new_config_dict['xcode_settings']['SDKROOT'] = 'iphoneos'
       target_dict['configurations'][new_config_name] = new_config_dict
   return targets
 
 def CloneConfigurationForDeviceAndEmulator(target_dicts):
   """If |target_dicts| contains any iOS targets, automatically create -iphoneos
   targets for iOS device builds."""
   if _HasIOSTarget(target_dicts):
     return _AddIOSDeviceConfigurations(target_dicts)
   return target_dicts