ninja/mac: Support iOS codesign for ninja builds.

pylib/gyp/generator/ninja.py

 # Copyright (c) 2013 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import hashlib
 import json
 import multiprocessing
 import os.path
 import re
@@ skipping 1196 matching lines @@
     if output_binary is not None:
       target_postbuilds = self.xcode_settings.GetTargetPostbuilds(
           self.config_name,
           os.path.normpath(os.path.join(self.base_to_build, output)),
           QuoteShellArgument(
               os.path.normpath(os.path.join(self.base_to_build, output_binary)),
               self.flavor),
           quiet=True)
     postbuilds = gyp.xcode_emulation.GetSpecPostbuildCommands(spec, quiet=True)
     postbuilds = target_postbuilds + postbuilds
+    if self.target.type == "executable" and output_binary is not None:

[Nico, 2013/10/14 16:54:55]

Does codesigning run before or after explicit "postbuild" entries in your gyp
file? (Does chrome/ios use explicit postbuilds?)

[justincohen, 2013/10/14 16:59:12]

It runs after -- very last step.

On 2013/10/14 16:54:55, Nico wrote:

[Nico, 2013/10/14 17:02:24]

Hm, that's annoying :-/

Maybe we should change the emulation api to be like:

postbuilds = self.xcode_settings.AddImplicitPostbuilds(postbuilds, ...)

and then the strip and codesign steps could both be added there (the first in
front, the second in the back). Having two calls to add implicit postbuilds is
somewhat lame

Be sure to have tests that check that codesigning runs after regular postbuilds.

+      postbuilds = self.xcode_settings.GetIOSPostbuilds(
+          self.config_name,
+          QuoteShellArgument(
+              os.path.normpath(os.path.join(self.base_to_build, output_binary)),
+              self.flavor),
+          postbuilds)
+
     if not postbuilds:
       return ''
     # Postbuilds expect to be run in the gyp file's directory, so insert an
     # implicit postbuild to cd to there.
     postbuilds.insert(0, gyp.common.EncodePOSIXShellList(
         ['cd', self.build_to_base]))
     env = self.ComputeExportEnvString(self.GetSortedXcodePostbuildEnv())
     # G will be non-null if any postbuild fails. Run all postbuilds in a
     # subshell.
     commands = env + ' (' + \
@@ skipping 898 matching lines @@
           arglists.append(
               (target_list, target_dicts, data, params, config_name))
         pool.map(CallGenerateOutputForConfig, arglists)
       except KeyboardInterrupt, e:
         pool.terminate()
         raise e
     else:
       for config_name in config_names:
         GenerateOutputForConfig(target_list, target_dicts, data, params,
                                 config_name)