Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html

Issue 2689483007: Tests of ctrl-click can't postMessage to opener - using custom text instead. (Closed)
Patch Set: Rebasing... Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html b/third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html
index d4d0bf3362bcc587e182c3b9d913daa792bf4d6f..9956c01efa943b3d165b8d696976c6adf70e8419 100644
--- a/third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html
+++ b/third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html
@@ -6,23 +6,12 @@
</form>
</div>
<div id="console"></div>
-<script src="/js-test-resources/js-test.js"></script>
<script>
-var results;
-function concludeTest(data)
-{
- results = data;
- shouldBeEqualToString('results["method"]', 'POST');
- shouldBeEqualToString('results["formValue"]', 'b');
-
- document.getElementById('container').outerHTML = '';
- finishJSTest();
-}
-
if (window.testRunner) {
- window.jsTestIsAsync = true;
+ testRunner.dumpAsText();
testRunner.setCanOpenWindows(true);
testRunner.setCloseRemainingWindowsWhenComplete(true);
+ testRunner.waitUntilDone();
window.onload = function() {
var submit = document.querySelector('input[type="submit"]');
@@ -31,15 +20,5 @@ if (window.testRunner) {
eventSender.mouseDown(0);
eventSender.mouseUp(0, ['shiftKey']);
};
-
- // Shift-clicking doesn't set window.opener, so we allow the new window
- // to find the opener using the name being set below.
- // TODO(lukasza): After fixing https://crbug.com/658386, the test will
- // need to use another mechanism for communicating verification results
- // (most likely OOPIF-replicated testRunner.setCustomTextOutput).
- window.name = "mainTestWindow";
- window.addEventListener('message', function(e) {
- concludeTest(e.data);
- });
}
</script>

Powered by Google App Engine
This is Rietveld 408576698