Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: media/base/audio_parameters.h

Issue 2689483006: Switch browser side audio capture path to use base time primitives. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/audio/pulse/pulse_input.cc ('K') | « media/base/audio_capturer_source.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_parameters.h
diff --git a/media/base/audio_parameters.h b/media/base/audio_parameters.h
index 68fbd54754f51c9254e0cc827508e2e11d14c05f..ff859b87d0854179ae396f1e303aaed34bd3ccbe 100644
--- a/media/base/audio_parameters.h
+++ b/media/base/audio_parameters.h
@@ -35,14 +35,15 @@ static_assert(AudioBus::kChannelAlignment == PARAMETERS_ALIGNMENT,
struct MEDIA_EXPORT ALIGNAS(PARAMETERS_ALIGNMENT) AudioInputBufferParameters {
double volume;
uint32_t size;
- uint32_t hardware_delay_bytes;
+ int64_t delay; // delay in microseconds
+ int64_t delay_timestamp; // base::TimeTicks in microseconds.
uint32_t id;
bool key_pressed;
};
struct MEDIA_EXPORT ALIGNAS(PARAMETERS_ALIGNMENT) AudioOutputBufferParameters {
uint32_t frames_skipped;
- int64_t delay;
- int64_t delay_timestamp;
+ int64_t delay; // delay in microseconds.
+ int64_t delay_timestamp; // base::TimeTicks in microseconds.
o1ka 2017/02/10 13:28:50 These comments look confusing to me.
DaleCurtis 2017/02/11 01:43:13 Do you have a suggestion? I was trying to indicate
o1ka 2017/02/13 14:00:21 Now basing on your other replies I got the concept
};
#undef PARAMETERS_ALIGNMENT
#if defined(OS_WIN)
« media/audio/pulse/pulse_input.cc ('K') | « media/base/audio_capturer_source.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698