Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 268943002: Add hpack_fuzz_wrapper to chromium_builder_asan (re-apply). (Closed)

Created:
6 years, 7 months ago by Johnny
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add hpack_fuzz_wrapper to chromium_builder_asan (re-apply). Also move hpack fuzz targets to build on mac & win, and tweak fuzzer tools to build on win. Re-applied patch from issue 266003005. TESTED=Manually built on windows. BUG=353237 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268286

Patch Set 1 #

Patch Set 2 : Also disable warning C4267. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -37 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/net.gyp View 1 2 chunks +39 lines, -33 lines 0 comments Download
M net/spdy/fuzzing/hpack_example_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_mutator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/spdy/fuzzing/hpack_fuzz_wrapper.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnny
I'm not sure why this wasn't picked up by the CQ in the previous land. ...
6 years, 7 months ago (2014-05-04 15:54:24 UTC) #1
Ryan Hamilton
On 2014/05/04 15:54:24, Johnny wrote: > I'm not sure why this wasn't picked up by ...
6 years, 7 months ago (2014-05-05 04:00:26 UTC) #2
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-05 15:10:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/268943002/20001
6 years, 7 months ago (2014-05-05 15:11:19 UTC) #4
Johnny
It was reverted; I didn't realize updating the closed commit was an option. Will do ...
6 years, 7 months ago (2014-05-05 15:15:35 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 22:03:17 UTC) #6
Message was sent while issue was closed.
Change committed as 268286

Powered by Google App Engine
This is Rietveld 408576698