Experimental bookmark model based on tags.

chrome/browser/bookmarks/bookmark_model.cc

Index: chrome/browser/bookmarks/bookmark_model.cc
diff --git a/chrome/browser/bookmarks/bookmark_model.cc b/chrome/browser/bookmarks/bookmark_model.cc
index f118e55cbfa69b5ba51d032f28b154e5c41de910..44ba951558a19066973d23dded4c54a87efabc11 100644
--- a/chrome/browser/bookmarks/bookmark_model.cc
+++ b/chrome/browser/bookmarks/bookmark_model.cc
@@ -496,14 +496,26 @@ void BookmarkModel::SetURL(const BookmarkNode* node, const GURL& url) {
 void BookmarkModel::SetNodeMetaInfo(const BookmarkNode* node,
                                     const std::string& key,
                                     const std::string& value) {
+  FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,

[sky, 2013/10/11 21:57:41]

Two places that I don't believe track meta data yet: undo and copy/paste (drag
and drop use the same code). Since this is experimental, TODOs are fine for now.

+                    OnWillChangeBookmarkMetaInfo(this, node));

[sky, 2013/10/11 21:57:41]

Can you only notify if something actually changes? To make this easy
BookmarkModel could get the metadata as a string, create a new string with the
contents (effectively what SetMetaInfo() does now). If the two are the same
early out, otherwise notify observers, apply the change (simple string swap),
notify again.

+
   if (AsMutable(node)->SetMetaInfo(key, value) && store_.get())
     store_->ScheduleSave();
+
+  FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
+                    BookmarkMetaInfoChanged(this, node));
 }
 
 void BookmarkModel::DeleteNodeMetaInfo(const BookmarkNode* node,
                                        const std::string& key) {
+  FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
+                    OnWillChangeBookmarkMetaInfo(this, node));
+
   if (AsMutable(node)->DeleteMetaInfo(key) && store_.get())
     store_->ScheduleSave();
+
+  FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
+                    BookmarkMetaInfoChanged(this, node));
 }
 
 void BookmarkModel::SetDateAdded(const BookmarkNode* node,