Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: chrome/browser/bookmarks/bookmark_model.cc

Issue 26894002: Experimental bookmark model based on tags. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixing trybot failures. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/bookmarks/bookmark_model.h" 5 #include "chrome/browser/bookmarks/bookmark_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <functional> 8 #include <functional>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 if (store_.get()) 489 if (store_.get())
490 store_->ScheduleSave(); 490 store_->ScheduleSave();
491 491
492 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_, 492 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
493 BookmarkNodeChanged(this, node)); 493 BookmarkNodeChanged(this, node));
494 } 494 }
495 495
496 void BookmarkModel::SetNodeMetaInfo(const BookmarkNode* node, 496 void BookmarkModel::SetNodeMetaInfo(const BookmarkNode* node,
497 const std::string& key, 497 const std::string& key,
498 const std::string& value) { 498 const std::string& value) {
499 // TODO(noyau): Right now the notification is send even if the meta info
500 // doesn't change. Checking first with the current API will decode the meta
501 // info twice, a non optimal solution.
502 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
503 OnWillChangeBookmarkMetaInfo(this, node));
504
499 if (AsMutable(node)->SetMetaInfo(key, value) && store_.get()) 505 if (AsMutable(node)->SetMetaInfo(key, value) && store_.get())
500 store_->ScheduleSave(); 506 store_->ScheduleSave();
507
508 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
509 BookmarkMetaInfoChanged(this, node));
501 } 510 }
502 511
503 void BookmarkModel::DeleteNodeMetaInfo(const BookmarkNode* node, 512 void BookmarkModel::DeleteNodeMetaInfo(const BookmarkNode* node,
504 const std::string& key) { 513 const std::string& key) {
514 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
515 OnWillChangeBookmarkMetaInfo(this, node));
516
505 if (AsMutable(node)->DeleteMetaInfo(key) && store_.get()) 517 if (AsMutable(node)->DeleteMetaInfo(key) && store_.get())
506 store_->ScheduleSave(); 518 store_->ScheduleSave();
519
520 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,
521 BookmarkMetaInfoChanged(this, node));
507 } 522 }
508 523
509 void BookmarkModel::SetDateAdded(const BookmarkNode* node, 524 void BookmarkModel::SetDateAdded(const BookmarkNode* node,
510 base::Time date_added) { 525 base::Time date_added) {
511 if (!node) { 526 if (!node) {
512 NOTREACHED(); 527 NOTREACHED();
513 return; 528 return;
514 } 529 }
515 530
516 if (node->date_added() == date_added) 531 if (node->date_added() == date_added)
(...skipping 532 matching lines...) Expand 10 before | Expand all | Expand 10 after
1049 BookmarkPermanentNode* bb_node = 1064 BookmarkPermanentNode* bb_node =
1050 CreatePermanentNode(BookmarkNode::BOOKMARK_BAR); 1065 CreatePermanentNode(BookmarkNode::BOOKMARK_BAR);
1051 BookmarkPermanentNode* other_node = 1066 BookmarkPermanentNode* other_node =
1052 CreatePermanentNode(BookmarkNode::OTHER_NODE); 1067 CreatePermanentNode(BookmarkNode::OTHER_NODE);
1053 BookmarkPermanentNode* mobile_node = 1068 BookmarkPermanentNode* mobile_node =
1054 CreatePermanentNode(BookmarkNode::MOBILE); 1069 CreatePermanentNode(BookmarkNode::MOBILE);
1055 return new BookmarkLoadDetails(bb_node, other_node, mobile_node, 1070 return new BookmarkLoadDetails(bb_node, other_node, mobile_node,
1056 new BookmarkIndex(profile_), 1071 new BookmarkIndex(profile_),
1057 next_node_id_); 1072 next_node_id_);
1058 } 1073 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model_observer.h » ('j') | chrome/browser/bookmarks/bookmark_tag_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698