Experimental bookmark model based on tags.

chrome/chrome_browser.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       'target_name': 'browser',
       'type': 'static_library',
       'variables': { 'enable_wexit_time_destructors': 1, },
@@ skipping 274 matching lines @@
         'browser/bookmarks/bookmark_prompt_prefs.cc',
         'browser/bookmarks/bookmark_prompt_prefs.h',
         'browser/bookmarks/bookmark_service.cc',
         'browser/bookmarks/bookmark_service.h',
         'browser/bookmarks/bookmark_stats.cc',
         'browser/bookmarks/bookmark_stats.h',
         'browser/bookmarks/bookmark_storage.cc',
         'browser/bookmarks/bookmark_storage.h',
         'browser/bookmarks/bookmark_title_match.cc',
         'browser/bookmarks/bookmark_title_match.h',
+        'browser/bookmarks/bookmark_tag_model.cc',

[Yaron, 2013/10/11 10:50:41]

Condition this on the |enabled_enhanced_bookmarks| gyp variable to avoid
overhead. Actually, I see that it's never constructed. What's your plan there?
Will the existing BookmarkModel factory conditionally construct this? Does it
wrap the BookmarkModel and cause it to be loaded?

[noyau (Ping after 24h), 2013/10/11 12:09:21]

Well, it's compiled but removed at link time as nobody uses it yet. Conditioning
it on the |enabled_enhanced_bookmarks| will mean that this could be easily
broken by a change to BookmarkManager, and that the unit tests will not be run
by the bots.
I was thinking that for now the UI will simply create one of those as needed,
passing the BookmarkModel from the factory. We could always make a new factory
later to manage a singleton.

+        'browser/bookmarks/bookmark_tag_model.h',
+        'browser/bookmarks/bookmark_tag_model_observer.h',
         'browser/bookmarks/bookmark_utils.cc',
         'browser/bookmarks/bookmark_utils.h',
         'browser/browser_about_handler.cc',
         'browser/browser_about_handler.h',
         'browser/browser_process.cc',
         'browser/browser_process.h',
         'browser/browser_process_impl.cc',
         'browser/browser_process_impl.h',
         'browser/browser_process_platform_part.h',
         'browser/browser_process_platform_part_android.cc',
@@ skipping 3393 matching lines @@
             'package_name': 'org/chromium/chrome/browser/ui/toolbar',
             'template_deps': ['browser/ui/toolbar/toolbar_model_security_level_list.h'],
           },
           'includes': [ '../build/android/java_cpp_template.gypi' ],
         },
       ],
      },
     ],
   ],
 }