Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5882)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 2689383002: Commands should have consistent behaviors across different modes
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/browser_command_controller.cc ('K') | « chrome/browser/ui/browser_command_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index 22a62f7fa9311ca61ae57882003d026b6d767e54..a8239141abed27283969ec6e15268ea31652ea58 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -161,7 +161,7 @@ TEST_F(BrowserCommandControllerTest, IncognitoCommands) {
testprofile->SetGuestSession(true);
chrome::BrowserCommandController
::UpdateSharedCommandsForIncognitoAvailability(
- browser()->command_controller()->command_updater(), testprofile);
+ browser()->command_controller()->command_updater(), testprofile, false);
msw 2017/02/14 22:34:50 If we keep this flag, we should have test coverage
Hzj_jie 2017/02/15 02:00:49 Sure, more test cases are added.
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_SIGNIN));
@@ -171,7 +171,7 @@ TEST_F(BrowserCommandControllerTest, IncognitoCommands) {
IncognitoModePrefs::FORCED);
chrome::BrowserCommandController
::UpdateSharedCommandsForIncognitoAvailability(
- browser()->command_controller()->command_updater(), testprofile);
+ browser()->command_controller()->command_updater(), testprofile, false);
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_SHOW_SIGNIN));
« chrome/browser/ui/browser_command_controller.cc ('K') | « chrome/browser/ui/browser_command_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698