Commands should have consistent behaviors across different modes

chrome/browser/app_controller_mac.mm

Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 4f248343f7f799dd5ff33036365c7cdfb5f55228..cdc25fceb9aee0dc1c8867ca4131894d68f7dfa1 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -1497,7 +1497,7 @@ class AppControllerProfileObserver : public ProfileAttributesStorage::Observer {
 
   chrome::BrowserCommandController::
       UpdateSharedCommandsForIncognitoAvailability(
-          menuState_.get(), lastProfile_);
+          menuState_.get(), lastProfile_, false);

[msw, 2017/02/14 22:34:50]

How do you know the relevant window is not fullscreen here? (ditto below)
Should UpdateSharedCommandsForIncognitoAvailability be non-static and determine
|is_fullscreen| internally, like UpdateCommandsForIncognitoAvailability? Or can
we get the relevant browser and check that here (via
chrome::FindLastActiveWithProfile, chrome::GetLastActiveBrowser(), or like
menuNeedsUpdate)? You might want to ping a knowledgable cocoa reviewer; I don't
know our Mac code too well.

[Hzj_jie, 2017/02/15 02:00:49]

AFAIK, menuState_ here is the state of menu items. i.e. Even we do not reserve
new-incognitor-window function, we still need this menu item to be available.
I will definitely add the original owner of the logic into the review.

[msw, 2017/02/15 18:40:51]

Sorry, but I don't understand how your reply answers my primary question:
  How do you know the relevant window is not fullscreen here?
This now always disables IDC_NEW_INCOGNITO_WINDOW and IDC_NEW_WINDOW...

[Hzj_jie, 2017/02/15 21:20:16]

No, I do not know, and I do not think we are talking about a window here. When
is_fullscreen is false, the logic is consistent with existing one.

Monica (noms@) wrote this logic 2+ years ago, but she is not working on another
project now. I am still looking for her replacement.

But no matter, since I have reverted the change to
UpdateSharedCommandsForIncognitoAvailability() function, we do not need to
change this file anymore.

   profilePrefRegistrar_.reset(new PrefChangeRegistrar());
   profilePrefRegistrar_->Init(lastProfile_->GetPrefs());
   profilePrefRegistrar_->Add(
@@ -1505,7 +1505,8 @@ class AppControllerProfileObserver : public ProfileAttributesStorage::Observer {
       base::Bind(&chrome::BrowserCommandController::
                      UpdateSharedCommandsForIncognitoAvailability,
                  menuState_.get(),
-                 lastProfile_));
+                 lastProfile_,
+                 false));
 }
 
 - (void)applicationDidChangeScreenParameters:(NSNotification*)notification {