Commands should have consistent behaviors across different modes

chrome/browser/ui/browser_command_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_
 #define CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_
 
 #include <vector>
 
 #include "base/macros.h"
@@ skipping 52 matching lines @@
   void PrintingStateChanged();
   void LoadingStateChanged(bool is_loading, bool force);
   void ExtensionStateChanged();
 
   // Shared state updating: these functions are static and public to share with
   // outside code.
 
   // Updates the open-file state.
   static void UpdateOpenFileState(CommandUpdater* command_updater);
 
   // Update commands whose state depends on incognito mode availability and that

[msw, 2017/02/14 22:34:50]

nit: update comment

[Hzj_jie, 2017/02/15 02:00:49]

Done.

   // only depend on the profile.
   static void UpdateSharedCommandsForIncognitoAvailability(
       CommandUpdater* command_updater,
-      Profile* profile);
+      Profile* profile,
+      bool is_fullscreen);
 
  private:
   class InterstitialObserver;
 
   // Overridden from CommandUpdaterDelegate:
   void ExecuteCommandWithDisposition(int id, WindowOpenDisposition disposition)
       override;
 
   // Overridden from TabStripModelObserver:
   void TabInsertedAt(TabStripModel* tab_strip_model,
@@ skipping 104 matching lines @@
   PrefChangeRegistrar profile_pref_registrar_;
   PrefChangeRegistrar local_pref_registrar_;
   BooleanPrefMember pref_signin_allowed_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserCommandController);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_BROWSER_COMMAND_CONTROLLER_H_