Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: content/browser/download/download_job_unittest.cc

Issue 2689373003: Introduce ParallelDownloadJob. (Closed)
Patch Set: Make windows compiler happy. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include <memory>
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "content/browser/download/download_item_impl_delegate.h"
8 #include "content/browser/download/download_job.h" 9 #include "content/browser/download/download_job.h"
10 #include "content/browser/download/mock_download_item_impl.h"
9 #include "content/browser/download/mock_download_job.h" 11 #include "content/browser/download/mock_download_job.h"
12 #include "content/public/test/test_browser_thread_bundle.h"
10 #include "testing/gmock/include/gmock/gmock.h" 13 #include "testing/gmock/include/gmock/gmock.h"
11 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
12 15
13 namespace content { 16 namespace content {
14 17
15 class MockDownloadJobManager : public DownloadJob::Manager {
16 public:
17 MockDownloadJobManager() = default;
18 ~MockDownloadJobManager() = default;
19
20 MOCK_METHOD1(OnSavingStarted, void(DownloadJob* download_job));
21 MOCK_METHOD1(SetDangerType, void(DownloadDangerType));
22 MOCK_METHOD2(OnDownloadInterrupted,
23 void(DownloadJob* download_job, DownloadInterruptReason reason));
24 MOCK_METHOD1(OnDownloadComplete, void(DownloadJob* download_job));
25 };
26
27 // Test for DownloadJob base class functionalities. 18 // Test for DownloadJob base class functionalities.
28 class DownloadJobTest : public testing::Test { 19 class DownloadJobTest : public testing::Test {
29 public: 20 public:
30 DownloadJobTest() = default; 21 DownloadJobTest() = default;
31 ~DownloadJobTest() override = default; 22 ~DownloadJobTest() override = default;
32 23
33 void SetUp() override { 24 void SetUp() override {
34 download_job_manager_ = base::MakeUnique<MockDownloadJobManager>(); 25 item_delegate_ = base::MakeUnique<DownloadItemImplDelegate>();
35 EXPECT_TRUE(download_job_manager_.get()); 26 download_item_ =
27 base::MakeUnique<MockDownloadItemImpl>(item_delegate_.get());
36 download_job_ = base::MakeUnique<MockDownloadJob>(); 28 download_job_ = base::MakeUnique<MockDownloadJob>();
37 } 29 }
38 30
39 std::unique_ptr<MockDownloadJobManager> download_job_manager_; 31 content::TestBrowserThreadBundle browser_threads_;
32 std::unique_ptr<DownloadItemImplDelegate> item_delegate_;
33 std::unique_ptr<MockDownloadItemImpl> download_item_;
40 std::unique_ptr<MockDownloadJob> download_job_; 34 std::unique_ptr<MockDownloadJob> download_job_;
41 }; 35 };
42 36
43 TEST_F(DownloadJobTest, AttachAndDetach) { 37 TEST_F(DownloadJobTest, AttachDownloadItem) {
44 // Ensure the manager should be valid only between attach and detach call. 38 download_job_->Attach(download_item_.get());
45 EXPECT_FALSE(download_job_->manager()); 39 DCHECK(download_job_->download_item());
46 download_job_->OnAttached(download_job_manager_.get());
47 EXPECT_TRUE(download_job_->manager());
48 download_job_->OnBeforeDetach();
49 EXPECT_FALSE(download_job_->manager());
50 } 40 }
51 41
52 } // namespace content 42 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698