chrome/browser/ui/views/payments/payment_request_sheet_controller.cc - Issue 2689363004: [Payments] Add combobox support to editors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

Issue 2689363004: [Payments] Add combobox support to editors. (Closed)

Patch Set: addressed comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc ('K') | « chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc ('k') | chrome/browser/ui/views/payments/preselected_combobox_model.h » ('j') | chrome/browser/ui/views/payments/preselected_combobox_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

index dacbde528177e8f6386b8d62f701d698d7a4940d..0df7ba0fcaebd79ce2fb1791e6d94ccd5d436ad3 100644

--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

@@ -19,8 +19,6 @@ namespace payments {

PaymentRequestSheetController::PaymentRequestSheetController(

PaymentRequest* request, PaymentRequestDialogView* dialog)

: request_(request), dialog_(dialog) {

- DCHECK(request_);

- DCHECK(dialog_);

}

std::unique_ptr<views::Button>