chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h - Issue 2689363004: [Payments] Add combobox support to editors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h

Issue 2689363004: [Payments] Add combobox support to editors. (Closed)

Patch Set: re-enable test, addressed comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_credit_card_editor_interactive_uitest.cc ('k') | chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h

diff --git a/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h b/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h

index 373d978f7dd0301e289b3d6cb646cc7ed3c47632..b111131d61ad88b941b5956d2fe4c3ad8eb1d928 100644

--- a/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h

+++ b/chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h

@@ -86,10 +86,14 @@ class PaymentRequestInteractiveTestBase

// Setting the |value| in the textfield of a given |type|.

void SetEditorTextfieldValue(const base::string16& value,

autofill::ServerFieldType type);

+ // Setting the |value| in the combobox of a given |type|.

+ void SetComboboxValue(const base::string16& value,

+ autofill::ServerFieldType type);

- // Whether the editor textfield for the given |type| is currently in an

- // invalid state.

+ // Whether the editor textfield/combobox for the given |type| is currently in

+ // an invalid state.

bool IsEditorTextfieldInvalid(autofill::ServerFieldType type);

+ bool IsEditorComboboxInvalid(autofill::ServerFieldType type);

// Sets proper animation delegates and waits for animation to finish.

void WaitForAnimation();