[Payments] Add combobox support to editors.

chrome/browser/ui/views/payments/validating_combobox.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/ui/views/payments/validating_textfield.h"
+#include "chrome/browser/ui/views/payments/validating_combobox.h"
 
 #include <utility>
 
 namespace payments {
 
-ValidatingTextfield::ValidatingTextfield(
-    std::unique_ptr<ValidatingTextfield::Delegate> delegate)
-    : Textfield(), delegate_(std::move(delegate)) {}
+ValidatingCombobox::ValidatingCombobox(
+    std::unique_ptr<ui::ComboboxModel> model,
+    std::unique_ptr<ValidationDelegate> delegate)
+    : Combobox(std::move(model)), delegate_(std::move(delegate)) {}
 
-ValidatingTextfield::~ValidatingTextfield() {}
+ValidatingCombobox::~ValidatingCombobox() {}
 
-void ValidatingTextfield::OnBlur() {
-  Textfield::OnBlur();
+void ValidatingCombobox::OnBlur() {
+  Combobox::OnBlur();
 
   // The first validation should be on a blur. The subsequent validations will
   // occur when the content changes.
   if (!was_validated_) {

[please use gerrit instead, 2017/02/15 15:59:39]

Perhaps a better name would be "has_blurred_once_" or "was_blurred_"?

[Mathieu, 2017/02/15 19:55:51]

Done.

     was_validated_ = true;
     Validate();
   }
 }
 
-void ValidatingTextfield::OnContentsChanged() {
+void ValidatingCombobox::OnContentsChanged() {
   // Validation on every keystroke only happens if the field has been validated
   // before as part of a blur.
   if (!was_validated_)
     return;
 
   Validate();
 }
 
-void ValidatingTextfield::Validate() {
-  // ValidateTextfield may have side-effects, such as displaying errors.
-  SetInvalid(!delegate_->ValidateTextfield(this));
+void ValidatingCombobox::Validate() {
+  // ValidateCombobox may have side-effects, such as displaying errors.
+  SetInvalid(!delegate_->ValidateCombobox(this));
 }
 
 }  // namespace payments