Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: components/metrics/metrics_service_unittest.cc

Issue 2689323010: Split a MetricsLogStore object out of MetricsLogManager. (Closed)
Patch Set: Incorporate Feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service_unittest.cc
diff --git a/components/metrics/metrics_service_unittest.cc b/components/metrics/metrics_service_unittest.cc
index f4a264cafe10ebc3bcda4940279ee6b5da9065cd..3cfcea72c2e63ef2c5942cf2503c6ce567ca6a85 100644
--- a/components/metrics/metrics_service_unittest.cc
+++ b/components/metrics/metrics_service_unittest.cc
@@ -52,6 +52,7 @@ class TestMetricsService : public MetricsService {
~TestMetricsService() override {}
using MetricsService::log_manager;
+ using MetricsService::log_store;
private:
DISALLOW_COPY_AND_ASSIGN(TestMetricsService);
@@ -187,8 +188,8 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAfterCleanShutDown) {
service.InitializeMetricsRecordingState();
// No initial stability log should be generated.
- EXPECT_FALSE(service.log_manager()->has_unsent_logs());
- EXPECT_FALSE(service.log_manager()->has_staged_log());
+ EXPECT_FALSE(service.log_store()->has_unsent_logs());
+ EXPECT_FALSE(service.log_store()->has_staged_log());
// Ensure that HasInitialStabilityMetrics() is always called on providers,
// for consistency, even if other conditions already indicate their presence.
@@ -232,9 +233,9 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAtProviderRequest) {
service.InitializeMetricsRecordingState();
// The initial stability log should be generated and persisted in unsent logs.
- MetricsLogManager* log_manager = service.log_manager();
- EXPECT_TRUE(log_manager->has_unsent_logs());
- EXPECT_FALSE(log_manager->has_staged_log());
+ MetricsLogStore* log_store = service.log_store();
+ EXPECT_TRUE(log_store->has_unsent_logs());
+ EXPECT_FALSE(log_store->has_staged_log());
// Ensure that HasInitialStabilityMetrics() is always called on providers,
// for consistency, even if other conditions already indicate their presence.
@@ -246,12 +247,12 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAtProviderRequest) {
EXPECT_TRUE(test_provider->provide_stability_metrics_called());
// Stage the log and retrieve it.
- log_manager->StageNextLogForUpload();
- EXPECT_TRUE(log_manager->has_staged_log());
+ log_store->StageNextLog();
+ EXPECT_TRUE(log_store->has_staged_log());
std::string uncompressed_log;
- EXPECT_TRUE(compression::GzipUncompress(log_manager->staged_log(),
- &uncompressed_log));
+ EXPECT_TRUE(
+ compression::GzipUncompress(log_store->staged_log(), &uncompressed_log));
ChromeUserMetricsExtension uma_log;
EXPECT_TRUE(uma_log.ParseFromString(uncompressed_log));
@@ -300,9 +301,9 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAfterCrash) {
service.InitializeMetricsRecordingState();
// The initial stability log should be generated and persisted in unsent logs.
- MetricsLogManager* log_manager = service.log_manager();
- EXPECT_TRUE(log_manager->has_unsent_logs());
- EXPECT_FALSE(log_manager->has_staged_log());
+ MetricsLogStore* log_store = service.log_store();
+ EXPECT_TRUE(log_store->has_unsent_logs());
+ EXPECT_FALSE(log_store->has_staged_log());
// Ensure that HasInitialStabilityMetrics() is always called on providers,
// for consistency, even if other conditions already indicate their presence.
@@ -314,12 +315,12 @@ TEST_F(MetricsServiceTest, InitialStabilityLogAfterCrash) {
EXPECT_TRUE(test_provider->provide_stability_metrics_called());
// Stage the log and retrieve it.
- log_manager->StageNextLogForUpload();
- EXPECT_TRUE(log_manager->has_staged_log());
+ log_store->StageNextLog();
+ EXPECT_TRUE(log_store->has_staged_log());
std::string uncompressed_log;
- EXPECT_TRUE(compression::GzipUncompress(log_manager->staged_log(),
- &uncompressed_log));
+ EXPECT_TRUE(
+ compression::GzipUncompress(log_store->staged_log(), &uncompressed_log));
ChromeUserMetricsExtension uma_log;
EXPECT_TRUE(uma_log.ParseFromString(uncompressed_log));
@@ -389,7 +390,7 @@ TEST_F(MetricsServiceTest, RegisterSyntheticTrial) {
WaitUntilTimeChanges(base::TimeTicks::Now());
// Start a new log and ensure all three trials appear in it.
- service.log_manager_.FinishCurrentLog();
+ service.log_manager_.FinishCurrentLog(service.log_store());
service.log_manager_.BeginLoggingWithLog(
std::unique_ptr<MetricsLog>(new MetricsLog(
"clientID", 1, MetricsLog::ONGOING_LOG, &client, GetLocalState())));
@@ -399,7 +400,7 @@ TEST_F(MetricsServiceTest, RegisterSyntheticTrial) {
EXPECT_TRUE(HasSyntheticTrial(synthetic_trials, "TestTrial1", "Group2"));
EXPECT_TRUE(HasSyntheticTrial(synthetic_trials, "TestTrial2", "Group2"));
EXPECT_TRUE(HasSyntheticTrial(synthetic_trials, "TestTrial3", "Group3"));
- service.log_manager_.FinishCurrentLog();
+ service.log_manager_.FinishCurrentLog(service.log_store());
}
TEST_F(MetricsServiceTest, RegisterSyntheticMultiGroupFieldTrial) {
@@ -446,7 +447,7 @@ TEST_F(MetricsServiceTest, RegisterSyntheticMultiGroupFieldTrial) {
service.GetSyntheticFieldTrialsOlderThan(base::TimeTicks::Now(),
&synthetic_trials);
- service.log_manager_.FinishCurrentLog();
+ service.log_manager_.FinishCurrentLog(service.log_store());
}
TEST_F(MetricsServiceTest,

Powered by Google App Engine
This is Rietveld 408576698