Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: components/metrics/metrics_service.h

Issue 2689323010: Split a MetricsLogStore object out of MetricsLogManager. (Closed)
Patch Set: Incorporate Feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service.h
diff --git a/components/metrics/metrics_service.h b/components/metrics/metrics_service.h
index f283b23285fa493fe3bb299843474a36e621f717..c4c1dd7abf35b64e1d590ba31ce024493e24779b 100644
--- a/components/metrics/metrics_service.h
+++ b/components/metrics/metrics_service.h
@@ -31,6 +31,7 @@
#include "components/metrics/execution_phase.h"
#include "components/metrics/metrics_log.h"
#include "components/metrics/metrics_log_manager.h"
+#include "components/metrics/metrics_log_store.h"
#include "components/metrics/metrics_provider.h"
#include "components/metrics/net/network_metrics_provider.h"
#include "components/variations/synthetic_trials.h"
@@ -200,6 +201,7 @@ class MetricsService : public base::HistogramFlattener {
protected:
// Exposed for testing.
MetricsLogManager* log_manager() { return &log_manager_; }
+ MetricsLogStore* log_store() { return &log_store_; }
private:
friend class MetricsServiceAccessor;
@@ -367,6 +369,9 @@ class MetricsService : public base::HistogramFlattener {
// Manager for the various in-flight logs.
MetricsLogManager log_manager_;
+ // Store of logs ready to be uploaded.
+ MetricsLogStore log_store_;
+
// |histogram_snapshot_manager_| prepares histogram deltas for transmission.
base::HistogramSnapshotManager histogram_snapshot_manager_;

Powered by Google App Engine
This is Rietveld 408576698