components/metrics/persisted_logs_metrics_impl.h - Issue 2689323010: Split a MetricsLogStore object out of MetricsLogManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/persisted_logs_metrics_impl.h

Issue 2689323010: Split a MetricsLogStore object out of MetricsLogManager. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/persisted_logs_metrics_impl.h

diff --git a/components/metrics/persisted_logs_metrics_impl.h b/components/metrics/persisted_logs_metrics_impl.h

index 04daf01acfc64a3397c6619e63ae9254aa807ab4..544acf9ab679309f9d07cba421456604d59c6a4c 100644

--- a/components/metrics/persisted_logs_metrics_impl.h

+++ b/components/metrics/persisted_logs_metrics_impl.h

@@ -16,14 +16,11 @@ class PersistedLogsMetricsImpl : public PersistedLogsMetrics {

PersistedLogsMetricsImpl() {}

~PersistedLogsMetricsImpl() override {}

- PersistedLogs::LogReadStatus RecordLogReadStatus(

- PersistedLogs::LogReadStatus status) override;

+ // PersistedLogsMetrics:

+ void RecordLogReadStatus(PersistedLogsMetrics::LogReadStatus status) override;

void RecordCompressionRatio(

size_t compressed_size, size_t original_size) override;

void RecordDroppedLogSize(size_t size) override;

void RecordDroppedLogsNum(int dropped_logs_num) override;

private: