Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: components/ukm/ukm_service.cc

Issue 2689323010: Split a MetricsLogStore object out of MetricsLogManager. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ukm/persisted_logs_metrics_impl.cc ('k') | components/ukm/ukm_service_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ukm/ukm_service.h" 5 #include "components/ukm/ukm_service.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 kMinPersistedBytes, 115 kMinPersistedBytes,
116 kMaxLogRetransmitSize), 116 kMaxLogRetransmitSize),
117 initialize_started_(false), 117 initialize_started_(false),
118 initialize_complete_(false), 118 initialize_complete_(false),
119 log_upload_in_progress_(false), 119 log_upload_in_progress_(false),
120 self_ptr_factory_(this) { 120 self_ptr_factory_(this) {
121 DCHECK(pref_service_); 121 DCHECK(pref_service_);
122 DCHECK(client_); 122 DCHECK(client_);
123 DVLOG(1) << "UkmService::Constructor"; 123 DVLOG(1) << "UkmService::Constructor";
124 124
125 persisted_logs_.DeserializeLogs(); 125 persisted_logs_.LoadPersistedUnsentLogs();
126 126
127 base::Closure rotate_callback = 127 base::Closure rotate_callback =
128 base::Bind(&UkmService::RotateLog, self_ptr_factory_.GetWeakPtr()); 128 base::Bind(&UkmService::RotateLog, self_ptr_factory_.GetWeakPtr());
129 // MetricsServiceClient outlives UkmService, and 129 // MetricsServiceClient outlives UkmService, and
130 // MetricsReportingScheduler is tied to the lifetime of |this|. 130 // MetricsReportingScheduler is tied to the lifetime of |this|.
131 const base::Callback<base::TimeDelta(void)>& get_upload_interval_callback = 131 const base::Callback<base::TimeDelta(void)>& get_upload_interval_callback =
132 base::Bind(&metrics::MetricsServiceClient::GetStandardUploadInterval, 132 base::Bind(&metrics::MetricsServiceClient::GetStandardUploadInterval,
133 base::Unretained(client_)); 133 base::Unretained(client_));
134 scheduler_.reset(new ukm::MetricsReportingScheduler( 134 scheduler_.reset(new ukm::MetricsReportingScheduler(
135 rotate_callback, get_upload_interval_callback)); 135 rotate_callback, get_upload_interval_callback));
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 for (auto& provider : metrics_providers_) 180 for (auto& provider : metrics_providers_)
181 provider->OnRecordingDisabled(); 181 provider->OnRecordingDisabled();
182 182
183 scheduler_->Stop(); 183 scheduler_->Stop();
184 Flush(); 184 Flush();
185 } 185 }
186 186
187 void UkmService::Flush() { 187 void UkmService::Flush() {
188 if (initialize_complete_) 188 if (initialize_complete_)
189 BuildAndStoreLog(); 189 BuildAndStoreLog();
190 persisted_logs_.SerializeLogs(); 190 persisted_logs_.PersistUnsentLogs();
191 } 191 }
192 192
193 void UkmService::Purge() { 193 void UkmService::Purge() {
194 DVLOG(1) << "UkmService::Purge"; 194 DVLOG(1) << "UkmService::Purge";
195 persisted_logs_.Purge(); 195 persisted_logs_.Purge();
196 sources_.clear(); 196 sources_.clear();
197 } 197 }
198 198
199 void UkmService::ResetClientId() { 199 void UkmService::ResetClientId() {
200 client_id_ = GenerateClientId(pref_service_); 200 client_id_ = GenerateClientId(pref_service_);
(...skipping 22 matching lines...) Expand all
223 DCHECK(thread_checker_.CalledOnValidThread()); 223 DCHECK(thread_checker_.CalledOnValidThread());
224 DVLOG(1) << "UkmService::FinishedInitTask"; 224 DVLOG(1) << "UkmService::FinishedInitTask";
225 initialize_complete_ = true; 225 initialize_complete_ = true;
226 scheduler_->InitTaskComplete(); 226 scheduler_->InitTaskComplete();
227 } 227 }
228 228
229 void UkmService::RotateLog() { 229 void UkmService::RotateLog() {
230 DCHECK(thread_checker_.CalledOnValidThread()); 230 DCHECK(thread_checker_.CalledOnValidThread());
231 DCHECK(!log_upload_in_progress_); 231 DCHECK(!log_upload_in_progress_);
232 DVLOG(1) << "UkmService::RotateLog"; 232 DVLOG(1) << "UkmService::RotateLog";
233 if (persisted_logs_.empty()) { 233 if (!persisted_logs_.has_unsent_logs())
234 BuildAndStoreLog(); 234 BuildAndStoreLog();
235 }
236 StartScheduledUpload(); 235 StartScheduledUpload();
237 } 236 }
238 237
239 void UkmService::BuildAndStoreLog() { 238 void UkmService::BuildAndStoreLog() {
240 DCHECK(thread_checker_.CalledOnValidThread()); 239 DCHECK(thread_checker_.CalledOnValidThread());
241 DVLOG(1) << "UkmService::BuildAndStoreLog"; 240 DVLOG(1) << "UkmService::BuildAndStoreLog";
242 // Suppress generating a log if we have no new data to include. 241 // Suppress generating a log if we have no new data to include.
243 if (sources_.empty()) 242 if (sources_.empty())
244 return; 243 return;
245 244
(...skipping 15 matching lines...) Expand all
261 } 260 }
262 261
263 std::string serialized_log; 262 std::string serialized_log;
264 report.SerializeToString(&serialized_log); 263 report.SerializeToString(&serialized_log);
265 persisted_logs_.StoreLog(serialized_log); 264 persisted_logs_.StoreLog(serialized_log);
266 } 265 }
267 266
268 void UkmService::StartScheduledUpload() { 267 void UkmService::StartScheduledUpload() {
269 DCHECK(thread_checker_.CalledOnValidThread()); 268 DCHECK(thread_checker_.CalledOnValidThread());
270 DCHECK(!log_upload_in_progress_); 269 DCHECK(!log_upload_in_progress_);
271 if (persisted_logs_.empty()) { 270 if (!persisted_logs_.has_unsent_logs()) {
272 // No logs to send, so early out and schedule the next rotation. 271 // No logs to send, so early out and schedule the next rotation.
273 scheduler_->UploadFinished(true, /* has_unsent_logs */ false); 272 scheduler_->UploadFinished(true, /* has_unsent_logs */ false);
274 return; 273 return;
275 } 274 }
276 if (!persisted_logs_.has_staged_log()) 275 if (!persisted_logs_.has_staged_log())
277 persisted_logs_.StageLog(); 276 persisted_logs_.StageNextLog();
278 // TODO(holte): Handle data usage on cellular, etc. 277 // TODO(holte): Handle data usage on cellular, etc.
279 if (!log_uploader_) { 278 if (!log_uploader_) {
280 log_uploader_ = client_->CreateUploader( 279 log_uploader_ = client_->CreateUploader(
281 GetServerUrl(), kMimeType, base::Bind(&UkmService::OnLogUploadComplete, 280 GetServerUrl(), kMimeType, base::Bind(&UkmService::OnLogUploadComplete,
282 self_ptr_factory_.GetWeakPtr())); 281 self_ptr_factory_.GetWeakPtr()));
283 } 282 }
284 log_upload_in_progress_ = true; 283 log_upload_in_progress_ = true;
285 284
286 const std::string hash = 285 const std::string hash =
287 base::HexEncode(persisted_logs_.staged_log_hash().data(), 286 base::HexEncode(persisted_logs_.staged_log_hash().data(),
(...skipping 17 matching lines...) Expand all
305 if (upload_succeeded) { 304 if (upload_succeeded) {
306 UMA_HISTOGRAM_COUNTS_10000("UKM.LogSize.OnSuccess", log_size_bytes / 1024); 305 UMA_HISTOGRAM_COUNTS_10000("UKM.LogSize.OnSuccess", log_size_bytes / 1024);
307 } else if (response_code == 400) { 306 } else if (response_code == 400) {
308 // Bad syntax. Retransmission won't work. 307 // Bad syntax. Retransmission won't work.
309 discard_log = true; 308 discard_log = true;
310 } 309 }
311 310
312 if (upload_succeeded || discard_log) { 311 if (upload_succeeded || discard_log) {
313 persisted_logs_.DiscardStagedLog(); 312 persisted_logs_.DiscardStagedLog();
314 // Store the updated list to disk now that the removed log is uploaded. 313 // Store the updated list to disk now that the removed log is uploaded.
315 persisted_logs_.SerializeLogs(); 314 persisted_logs_.PersistUnsentLogs();
316 } 315 }
317 316
318 // Error 400 indicates a problem with the log, not with the server, so 317 // Error 400 indicates a problem with the log, not with the server, so
319 // don't consider that a sign that the server is in trouble. 318 // don't consider that a sign that the server is in trouble.
320 bool server_is_healthy = upload_succeeded || response_code == 400; 319 bool server_is_healthy = upload_succeeded || response_code == 400;
321 scheduler_->UploadFinished(server_is_healthy, !persisted_logs_.empty()); 320 scheduler_->UploadFinished(server_is_healthy,
321 persisted_logs_.has_unsent_logs());
322 } 322 }
323 323
324 void UkmService::RecordSource(std::unique_ptr<UkmSource> source) { 324 void UkmService::RecordSource(std::unique_ptr<UkmSource> source) {
325 if (!recording_enabled_) { 325 if (!recording_enabled_) {
326 RecordDroppedSource(DroppedSourceReason::RECORDING_DISABLED); 326 RecordDroppedSource(DroppedSourceReason::RECORDING_DISABLED);
327 return; 327 return;
328 } 328 }
329 if (sources_.size() >= kMaxSources) { 329 if (sources_.size() >= kMaxSources) {
330 RecordDroppedSource(DroppedSourceReason::MAX_SOURCES_HIT); 330 RecordDroppedSource(DroppedSourceReason::MAX_SOURCES_HIT);
331 return; 331 return;
332 } 332 }
333 333
334 sources_.push_back(std::move(source)); 334 sources_.push_back(std::move(source));
335 } 335 }
336 336
337 } // namespace ukm 337 } // namespace ukm
OLDNEW
« no previous file with comments | « components/ukm/persisted_logs_metrics_impl.cc ('k') | components/ukm/ukm_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698