Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: media/blink/multibuffer_data_source_unittest.cc

Issue 2689323002: Media: Delete Pause-To-Buffer. (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/multibuffer_data_source.cc ('k') | media/blink/webmediaplayer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/multibuffer_data_source_unittest.cc
diff --git a/media/blink/multibuffer_data_source_unittest.cc b/media/blink/multibuffer_data_source_unittest.cc
index 993aa921a1e913d7b466a669fc6056e59ea9953a..4fb90d9c6f25ed982d9ddb3ac9f9d8af615e314d 100644
--- a/media/blink/multibuffer_data_source_unittest.cc
+++ b/media/blink/multibuffer_data_source_unittest.cc
@@ -1109,10 +1109,6 @@ TEST_F(MultibufferDataSourceTest, LocalResource_DeferStrategy) {
data_source_->MediaIsPlaying();
CheckCapacityDefer();
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_AGGRESSIVE);
- CheckCapacityDefer();
-
Stop();
}
@@ -1127,10 +1123,6 @@ TEST_F(MultibufferDataSourceTest, LocalResource_PreloadMetadata_DeferStrategy) {
data_source_->MediaIsPlaying();
CheckCapacityDefer();
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_AGGRESSIVE);
- CheckCapacityDefer();
-
Stop();
}
@@ -1145,10 +1137,6 @@ TEST_F(MultibufferDataSourceTest, ExternalResource_Reponse200_DeferStrategy) {
data_source_->MediaIsPlaying();
CheckCapacityDefer();
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_AGGRESSIVE);
- CheckCapacityDefer();
-
Stop();
}
@@ -1165,10 +1153,6 @@ TEST_F(MultibufferDataSourceTest,
data_source_->MediaIsPlaying();
CheckCapacityDefer();
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_AGGRESSIVE);
- CheckCapacityDefer();
-
Stop();
}
@@ -1182,21 +1166,11 @@ TEST_F(MultibufferDataSourceTest, ExternalResource_Reponse206_DeferStrategy) {
data_source_->MediaIsPlaying();
CheckCapacityDefer();
- set_might_be_reused_from_cache_in_future(true);
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_AGGRESSIVE);
- CheckNeverDefer();
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_NORMAL);
+ set_might_be_reused_from_cache_in_future(true);
data_source_->MediaIsPlaying();
CheckCapacityDefer();
- set_might_be_reused_from_cache_in_future(false);
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_AGGRESSIVE);
- CheckCapacityDefer();
-
Stop();
}
@@ -1214,17 +1188,10 @@ TEST_F(MultibufferDataSourceTest,
CheckCapacityDefer();
set_might_be_reused_from_cache_in_future(true);
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_AGGRESSIVE);
- CheckNeverDefer();
-
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_NORMAL);
data_source_->MediaIsPlaying();
CheckCapacityDefer();
+
set_might_be_reused_from_cache_in_future(false);
- data_source_->SetBufferingStrategy(
- MultibufferDataSource::BUFFERING_STRATEGY_AGGRESSIVE);
CheckCapacityDefer();
Stop();
« no previous file with comments | « media/blink/multibuffer_data_source.cc ('k') | media/blink/webmediaplayer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698