Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2689283012: Fix type of NamedTypeBuilder.builder. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M pkg/front_end/lib/src/fasta/builder/named_type_builder.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
ahe
3 years, 10 months ago (2017-02-17 20:32:04 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-17 21:11:23 UTC) #3
Paul Berry
lgtm
3 years, 10 months ago (2017-02-17 21:15:41 UTC) #4
ahe
I think it's too late for me to land this, so I plan on landing ...
3 years, 10 months ago (2017-02-17 21:35:09 UTC) #5
ahe
3 years, 10 months ago (2017-02-20 08:37:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d45990a655e209b35f0fb154fbbd51e679957c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698