Fix appearance of header row separators in table view at fractional

ui/gfx/canvas.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/canvas.h"
 
 #include <cmath>
 #include <limits>
 
 #include "base/i18n/rtl.h"
@@ skipping 303 matching lines @@
   DrawLine(PointF(p1), PointF(p2), flags);
 }
 
 void Canvas::DrawLine(const PointF& p1,
                       const PointF& p2,
                       const cc::PaintFlags& flags) {
   canvas_->drawLine(SkFloatToScalar(p1.x()), SkFloatToScalar(p1.y()),
                     SkFloatToScalar(p2.x()), SkFloatToScalar(p2.y()), flags);
 }
 
+void Canvas::DrawSharpLine(const PointF& p1, const PointF& p2, SkColor color) {
+  ScopedCanvas scoped(this);
+  float dsf = UndoDeviceScaleFactor();
+
+  PointF start = p1;

[Peter Kasting, 2017/02/15 00:43:59]

Nit: If you're just going to copy these anyway, I suggest passing them to the
function by value and then scaling the args directly.  This lets the compiler be
more efficient in some cases (when caller structs don't have to be forced to the
stack).

[Evan Stade, 2017/02/15 16:54:46]

I thought we never passed non-PODs by value and coverity at least used to
complain about that. Anyway I changed this and one other function in this file.

+  start.Scale(dsf);
+  PointF end = p2;
+  end.Scale(dsf);
+
+  cc::PaintFlags flags;
+  flags.setColor(color);
+  flags.setStrokeWidth(std::floor(dsf));

[Evan Stade, 2017/02/14 23:06:03]

I guess I could use gfx::ToFlooredInt for this, but what's wrong with
std::floor?

[Peter Kasting, 2017/02/15 00:43:59]

floor() returns a float, which is potentially outside the representable range
for an int (and also isn't an int typewise).

In this case, you're trying to convert back to a floating-point type anyway, so
I'd do SkFloatToScalar(std::floor()) instead of trying to go through
ToFlooredInt.

[Evan Stade, 2017/02/15 16:54:46]

Done.

+
+  DrawLine(start, end, flags);
+}
+
 void Canvas::DrawCircle(const Point& center_point,
                         int radius,
                         const cc::PaintFlags& flags) {
   DrawCircle(PointF(center_point), radius, flags);
 }
 
 void Canvas::DrawCircle(const PointF& center_point,
                         float radius,
                         const cc::PaintFlags& flags) {
   canvas_->drawCircle(SkFloatToScalar(center_point.x()),
@@ skipping 266 matching lines @@
   flags.setFilterQuality(filter ? kLow_SkFilterQuality : kNone_SkFilterQuality);
   flags.setShader(CreateImageRepShaderForScale(
       image_rep, SkShader::kRepeat_TileMode, shader_scale,
       remove_image_scale ? image_rep.scale() : 1.f));
 
   // The rect will be filled by the bitmap.
   canvas_->drawRect(dest_rect, flags);
 }
 
 }  // namespace gfx