Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: chrome/install_static/chromium_install_modes.cc

Issue 2689233005: Move brand- and mode-specific app icon resource id into InstallConstants. (Closed)
Patch Set: sync to position 453103 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/install_static/DEPS ('k') | chrome/install_static/google_chrome_install_modes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Brand-specific constants and install modes for Chromium. 5 // Brand-specific constants and install modes for Chromium.
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include "chrome/app/chrome_dll_resource.h"
9 #include "chrome/install_static/install_modes.h" 10 #include "chrome/install_static/install_modes.h"
10 11
11 namespace install_static { 12 namespace install_static {
12 13
13 const wchar_t kCompanyPathName[] = L""; 14 const wchar_t kCompanyPathName[] = L"";
14 15
15 const wchar_t kProductPathName[] = L"Chromium"; 16 const wchar_t kProductPathName[] = L"Chromium";
16 17
17 const size_t kProductPathNameLength = _countof(kProductPathName) - 1; 18 const size_t kProductPathNameLength = _countof(kProductPathName) - 1;
18 19
19 // No integration with Google Update, so no app GUID. 20 // No integration with Google Update, so no app GUID.
20 const wchar_t kBinariesAppGuid[] = L""; 21 const wchar_t kBinariesAppGuid[] = L"";
21 22
22 const wchar_t kBinariesPathName[] = L"Chromium Binaries"; 23 const wchar_t kBinariesPathName[] = L"Chromium Binaries";
23 24
24 const InstallConstants kInstallModes[] = { 25 const InstallConstants kInstallModes[] = {
25 // clang-format off 26 // clang-format off
26 // The primary (and only) install mode for Chromium. 27 // The primary (and only) install mode for Chromium.
27 { 28 {
28 sizeof(kInstallModes[0]), 29 sizeof(kInstallModes[0]),
29 CHROMIUM_INDEX, 30 CHROMIUM_INDEX,
30 "", // No install switch for the primary install mode. 31 "", // No install switch for the primary install mode.
31 L"", // Empty install_suffix for the primary install mode. 32 L"", // Empty install_suffix for the primary install mode.
32 L"", // No logo suffix for the primary install mode. 33 L"", // No logo suffix for the primary install mode.
33 L"", // Empty app_guid since no integraion with Google Update. 34 L"", // Empty app_guid since no integraion with Google Update.
34 L"", // Empty default channel name as above. 35 L"", // Empty default channel name as above.
35 ChannelStrategy::UNSUPPORTED, 36 ChannelStrategy::UNSUPPORTED,
36 true, // Supports system-level installs. 37 true, // Supports system-level installs.
37 true, // Supported multi-install. 38 true, // Supported multi-install.
39 IDR_MAINFRAME,
38 }, 40 },
39 // clang-format on 41 // clang-format on
40 }; 42 };
41 43
42 static_assert(_countof(kInstallModes) == NUM_INSTALL_MODES, 44 static_assert(_countof(kInstallModes) == NUM_INSTALL_MODES,
43 "Imbalance between kInstallModes and InstallConstantIndex"); 45 "Imbalance between kInstallModes and InstallConstantIndex");
44 46
45 } // namespace install_static 47 } // namespace install_static
OLDNEW
« no previous file with comments | « chrome/install_static/DEPS ('k') | chrome/install_static/google_chrome_install_modes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698