chrome/install_static/DEPS - Issue 2689233005: Move brand- and mode-specific app icon resource id into InstallConstants.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/install_static/DEPS

Issue 2689233005: Move brand- and mode-specific app icon resource id into InstallConstants. (Closed)

Patch Set: sync to position 453103 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Nothing from base.	2 # Nothing from base.

3 "-base",	3 "-base",

4 # Nothing from chrome.	4 # Nothing from chrome.

5 "-chrome",	5 "-chrome",

	6 # For the app icon resource indices.

	7 "+chrome/app/chrome_dll_resource.h",

6 # Anything from this dir.	8 # Anything from this dir.

7 "+chrome/install_static",	9 "+chrome/install_static",

8 # All registry access should go through nt_registry.	10 # All registry access should go through nt_registry.

9 "+chrome_elf/nt_registry/nt_registry.h",	11 "+chrome_elf/nt_registry/nt_registry.h",

10 # For the compile-time PRODUCT_VERSION macro.	12 # For the compile-time PRODUCT_VERSION macro.

11 "+components/version_info/version_info_values.h",	13 "+components/version_info/version_info_values.h",

12 ]	14 ]

13	15

14 specific_include_rules = {	16 specific_include_rules = {

15 ".*_unittest\.cc": [	17 ".*_unittest\.cc": [

16 "+base",	18 "+base",

17 ],	19 ],

18 }	20 }

OLD	NEW

« no previous file with comments | « chrome/install_static/BUILD.gn ('k') | chrome/install_static/chromium_install_modes.cc » ('j') | no next file with comments »