Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: chrome/browser/apps/app_browsertest.cc

Issue 2689213017: Disable PlatformAppBrowserTest.WindowDotPrintShouldBringUpPrintPreview (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "apps/launcher.h" 9 #include "apps/launcher.h"
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 1113 matching lines...) Expand 10 before | Expand all | Expand 10 after
1124 1124
1125 EXPECT_EQ(1LU, GetAppWindowCount()); 1125 EXPECT_EQ(1LU, GetAppWindowCount());
1126 EXPECT_TRUE(GetFirstAppWindow() 1126 EXPECT_TRUE(GetFirstAppWindow()
1127 ->web_contents() 1127 ->web_contents()
1128 ->GetRenderWidgetHostView() 1128 ->GetRenderWidgetHostView()
1129 ->HasFocus()); 1129 ->HasFocus());
1130 } 1130 }
1131 1131
1132 #if BUILDFLAG(ENABLE_PRINT_PREVIEW) 1132 #if BUILDFLAG(ENABLE_PRINT_PREVIEW)
1133 1133
1134 // Disabled due to flakiness. See crbug.com/693305.
1135 // TODO(rbpotter): Investigate and re-enable this test.
1134 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, 1136 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
1135 WindowDotPrintShouldBringUpPrintPreview) { 1137 DISABLED_WindowDotPrintShouldBringUpPrintPreview) {
1136 ScopedPreviewTestingDelegate preview_delegate; 1138 ScopedPreviewTestingDelegate preview_delegate;
1137 ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_; 1139 ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_;
1138 preview_delegate.WaitUntilPreviewIsReady(); 1140 preview_delegate.WaitUntilPreviewIsReady();
1139 } 1141 }
1140 1142
1141 // This test verifies that http://crbug.com/297179 is fixed. 1143 // This test verifies that http://crbug.com/297179 is fixed.
1142 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, 1144 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
1143 DISABLED_ClosingWindowWhilePrintingShouldNotCrash) { 1145 DISABLED_ClosingWindowWhilePrintingShouldNotCrash) {
1144 ScopedPreviewTestingDelegate preview_delegate; 1146 ScopedPreviewTestingDelegate preview_delegate;
1145 ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_; 1147 ASSERT_TRUE(RunPlatformAppTest("platform_apps/print_api")) << message_;
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
1364 // https://crbug.com/620194. 1366 // https://crbug.com/620194.
1365 #define MAYBE_AppWindowIframe DISABLED_AppWindowIframe 1367 #define MAYBE_AppWindowIframe DISABLED_AppWindowIframe
1366 // Sends chrome.test.sendMessage from chrome.app.window.create's callback. 1368 // Sends chrome.test.sendMessage from chrome.app.window.create's callback.
1367 // The app window also adds an <iframe> to the page during window.onload. 1369 // The app window also adds an <iframe> to the page during window.onload.
1368 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_AppWindowIframe) { 1370 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_AppWindowIframe) {
1369 LoadAndLaunchPlatformApp("app_window_send_message", 1371 LoadAndLaunchPlatformApp("app_window_send_message",
1370 "APP_WINDOW_CREATE_CALLBACK"); 1372 "APP_WINDOW_CREATE_CALLBACK");
1371 } 1373 }
1372 1374
1373 } // namespace extensions 1375 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698