Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2689213016: Issue 27214. Get any AnalysisDriver for getNavigation(). (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 27214. Get any AnalysisDriver for getNavigation(). This means that we will able to analyze any file, even outside all analysis roots. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/27214 Committed: https://github.com/dart-lang/sdk/commit/6d79ee2602d3dd5bd4b8322f111095481f1a8a53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_navigation_test.dart View 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 10 months ago (2017-02-17 17:08:47 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-17 17:11:52 UTC) #2
scheglov
3 years, 10 months ago (2017-02-17 17:14:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6d79ee2602d3dd5bd4b8322f111095481f1a8a53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698