Move previous border box size out of global map into LayoutBox::m_previousSize

third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/BoxPaintInvalidator.h"
 
 #include "core/frame/Settings.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/compositing/CompositedLayerMapping.h"
 #include "core/paint/ObjectPaintInvalidator.h"
 #include "core/paint/PaintInvalidator.h"
 #include "core/paint/PaintLayer.h"
 #include "core/paint/PaintLayerScrollableArea.h"
 #include "platform/geometry/LayoutRect.h"
 
 namespace blink {
 
 struct PreviousBoxGeometries {
-  LayoutSize borderBoxSize;
   LayoutRect contentBoxRect;
   LayoutRect layoutOverflowRect;
 };
 
 typedef HashMap<const LayoutBox*, PreviousBoxGeometries>
     PreviousBoxGeometriesMap;
 static PreviousBoxGeometriesMap& previousBoxGeometriesMap() {
   DEFINE_STATIC_LOCAL(PreviousBoxGeometriesMap, map, ());
   return map;
 }
@@ skipping 86 matching lines @@
   }
 
   const ComputedStyle& style = m_box.styleRef();
 
   if ((style.backgroundLayers().thisOrNextLayersUseContentBox() ||
        style.maskLayers().thisOrNextLayersUseContentBox() ||
        style.boxSizing() == EBoxSizing::kBorderBox) &&
       previousContentBoxRect() != m_box.contentBoxRect())
     return PaintInvalidationContentBoxChange;
 
-  LayoutSize oldBorderBoxSize =
-      previousBorderBoxSize(m_box, m_context.oldVisualRect.size());
+  LayoutSize oldBorderBoxSize = m_box.previousSize();
   LayoutSize newBorderBoxSize = m_box.size();
   bool borderBoxChanged = oldBorderBoxSize != newBorderBoxSize;
   if (!borderBoxChanged && m_context.oldVisualRect == m_context.newVisualRect)
     return PaintInvalidationNone;
 
   // If either border box changed or bounds changed, and old or new border box
   // doesn't equal old or new bounds, incremental invalidation is not
   // applicable. This captures the following cases:
   // - pixel snapping of paint invalidation bounds,
   // - scale, rotate, skew etc. transforms,
@@ skipping 87 matching lines @@
 
   bool shouldFullyInvalidateOnScrollingContentsLayer = false;
   if (m_box.backgroundChangedSinceLastPaintInvalidation()) {
     if (!paintsOntoScrollingContentsLayer) {
       // The box should have been set needing full invalidation on style change.
       DCHECK(m_box.shouldDoFullPaintInvalidation());
       return;
     }
     shouldFullyInvalidateOnScrollingContentsLayer = true;
   } else {
-    // Check change of layout overflow for incremental invalidation.
-    if (!m_box.hasPreviousBoxGeometries() ||
-        newLayoutOverflow == oldLayoutOverflow)
+    // Check change of layout overflow for full or incremental invalidation.
+    if (newLayoutOverflow == oldLayoutOverflow)
       return;
+    bool shouldFullyInvalidate =
+        shouldFullyInvalidateBackgroundOnLayoutOverflowChange(
+            oldLayoutOverflow, newLayoutOverflow);
     if (!paintsOntoScrollingContentsLayer) {
-      if (shouldFullyInvalidateBackgroundOnLayoutOverflowChange(
-              oldLayoutOverflow, newLayoutOverflow)) {
+      if (shouldFullyInvalidate) {
         m_box.getMutableForPainting().setShouldDoFullPaintInvalidation(
             PaintInvalidationLayoutOverflowBoxChange);
       }
       return;
     }
-    shouldFullyInvalidateOnScrollingContentsLayer =
-        shouldFullyInvalidateBackgroundOnLayoutOverflowChange(
-            oldLayoutOverflow, newLayoutOverflow);
+    shouldFullyInvalidateOnScrollingContentsLayer = shouldFullyInvalidate;
   }
 
   if (shouldFullyInvalidateOnScrollingContentsLayer) {
     ObjectPaintInvalidatorWithContext(m_box, m_context)
         .fullyInvalidatePaint(
             PaintInvalidationBackgroundOnScrollingContentsLayer,
             oldLayoutOverflow, newLayoutOverflow);
   } else {
     incrementallyInvalidatePaint(
         PaintInvalidationBackgroundOnScrollingContentsLayer, oldLayoutOverflow,
@@ skipping 13 matching lines @@
 
   PaintInvalidationReason reason = computePaintInvalidationReason();
   if (reason == PaintInvalidationIncremental) {
     bool invalidated;
     if (m_box.isLayoutView() &&
         !RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
       invalidated = incrementallyInvalidatePaint(
           reason, m_context.oldVisualRect, m_context.newVisualRect);
     } else {
       invalidated = incrementallyInvalidatePaint(
-          reason, LayoutRect(m_context.oldLocation,
-                             previousBorderBoxSize(
-                                 m_box, m_context.oldVisualRect.size())),
+          reason, LayoutRect(m_context.oldLocation, m_box.previousSize()),
           LayoutRect(m_context.newLocation, m_box.size()));
     }
     if (invalidated) {
       m_context.paintingLayer->setNeedsRepaint();
       m_box.invalidateDisplayItemClients(reason);
     } else {
       reason = PaintInvalidationNone;
     }
 
     // Though we have done incremental invalidation, we still need to call
@@ skipping 11 matching lines @@
   if (PaintLayerScrollableArea* area = m_box.getScrollableArea())
     area->invalidatePaintOfScrollControlsIfNeeded(m_context);
 
   // This is for the next invalidatePaintIfNeeded so must be at the end.
   savePreviousBoxGeometriesIfNeeded();
 
   return reason;
 }
 
 bool BoxPaintInvalidator::needsToSavePreviousBoxGeometries() {
-  LayoutSize paintInvalidationSize = m_context.newVisualRect.size();
+  // Don't save old box geometries if the paint rect is empty because we'll
+  // fully invalidate once the paint rect becomes non-empty.
+  if (m_context.newVisualRect.isEmpty())
+    return false;
 
-  // The shortcuts doesn't apply to HTML element. ViewPaintInvalidator needs to
-  // know its previous border box size even if it has visibility:hidden (causing
-  // empty paintInvalidationSize) or has no painted output.
-  if (!m_box.node() || !m_box.node()->isHTMLElement()) {
-    // Don't save old box geometries if the paint rect is empty because we'll
-    // fully invalidate once the paint rect becomes non-empty.
-    if (paintInvalidationSize.isEmpty())
-      return false;
-
-    if (m_box.paintedOutputOfObjectHasNoEffectRegardlessOfSize())
-      return false;
-  }
+  if (m_box.paintedOutputOfObjectHasNoEffectRegardlessOfSize())
+    return false;
 
   const ComputedStyle& style = m_box.styleRef();
 
   // If we use border-box sizing we need to track changes in the size of the
   // content box.
   if (style.boxSizing() == EBoxSizing::kBorderBox)
     return true;
 
-  // No need to save old border box size if we can use size of the old paint
-  // rect as the old border box size in the next invalidation.
-  if (paintInvalidationSize != m_box.size())
-    return true;
-
   // Background and mask layers can depend on other boxes than border box. See
   // crbug.com/490533
   if (style.backgroundLayers().thisOrNextLayersUseContentBox() ||
       style.maskLayers().thisOrNextLayersUseContentBox() ||
       backgroundGeometryDependsOnLayoutOverflowRect() ||
       backgroundPaintsOntoScrollingContentsLayer())
     return true;
 
   return false;
 }
 
 void BoxPaintInvalidator::savePreviousBoxGeometriesIfNeeded() {
+  m_box.getMutableForPainting().setPreviousSize(m_box.size());
+
   DCHECK(m_box.hasPreviousBoxGeometries() ==
          previousBoxGeometriesMap().contains(&m_box));
   if (!needsToSavePreviousBoxGeometries()) {
     if (m_box.hasPreviousBoxGeometries()) {
       previousBoxGeometriesMap().erase(&m_box);
       m_box.getMutableForPainting().setHasPreviousBoxGeometries(false);
     }
     return;
   }
 
-  PreviousBoxGeometries geometries = {m_box.size(), m_box.contentBoxRect(),
+  PreviousBoxGeometries geometries = {m_box.contentBoxRect(),
                                       m_box.layoutOverflowRect()};
   previousBoxGeometriesMap().set(&m_box, geometries);
   m_box.getMutableForPainting().setHasPreviousBoxGeometries(true);
 }
 
-LayoutSize BoxPaintInvalidator::previousBorderBoxSize(
-    const LayoutBox& box,
-    const LayoutSize& defaultSize) {
-  DCHECK(box.hasPreviousBoxGeometries() ==
-         previousBoxGeometriesMap().contains(&box));
-  if (box.hasPreviousBoxGeometries())
-    return previousBoxGeometriesMap().get(&box).borderBoxSize;
-  return defaultSize;
-}
-
 LayoutRect BoxPaintInvalidator::previousContentBoxRect() {
   DCHECK(m_box.hasPreviousBoxGeometries() ==
          previousBoxGeometriesMap().contains(&m_box));
   return m_box.hasPreviousBoxGeometries()
              ? previousBoxGeometriesMap().get(&m_box).contentBoxRect
-             : LayoutRect();
+             : LayoutRect(LayoutPoint(), m_box.previousSize());
 }
 
 LayoutRect BoxPaintInvalidator::previousLayoutOverflowRect() {
   DCHECK(m_box.hasPreviousBoxGeometries() ==
          previousBoxGeometriesMap().contains(&m_box));
   return m_box.hasPreviousBoxGeometries()
              ? previousBoxGeometriesMap().get(&m_box).layoutOverflowRect
-             : LayoutRect();
+             : LayoutRect(LayoutPoint(), m_box.previousSize());
 }
 
 }  // namespace blink