Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 2689213006: [Kernel] Replace --use-dfe with --no-dfe (Closed)

Created:
3 years, 10 months ago by jensj
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Kernel] Replace --use-dfe with --no-dfe Replace --use-dfe (defaulting to true) with --no-dfe (defaulting to false) so that it is still used by default, but it is actually possible to _not_ run with the kernel isolate and instead use dartk. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/7b11ede8c2583c7751ccd12bdbc64181b3e6f102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 10 months ago (2017-02-15 09:25:14 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 10 months ago (2017-02-15 10:06:48 UTC) #3
jensj
3 years, 10 months ago (2017-02-15 10:08:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b11ede8c2583c7751ccd12bdbc64181b3e6f102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698