Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2689213002: Use FFT from FFMpeg for OSX (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
CC:
Raymond Toy, blink-reviews, chromium-reviews, hongchan, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FFT from FFMpeg for OSX MacOS uses the vDSP library for the FFT routines. Replace these with the FFT from FFMpeg that is used on Linux and Windows. Some measurements using http://jsfiddle.net/gMKh9/ (from crbug.com/316740)as a benchmark. Test run using Macbook Pro 15" Retina (Mid 2014) vDSP: 413 ms 424 ms 428 ms 410 ms 432 ms Avg: 421.4 ms FFmpeg: 405 ms 401 ms 407 ms 425 ms 402 ms Avg: 408 ms About a 3% speed up. Not much, but using the same FFT as for linux and windows is good. BUG=680617 TEST=none

Patch Set 1 #

Patch Set 2 : Remove OSX support. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M third_party/WebKit/Source/config.gni View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/FFTFrame.h View 1 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Raymond Toy
3 years, 10 months ago (2017-02-14 03:40:28 UTC) #1
In patch #2, we really remove support for OSX.  The new timing results are:

749 ms
730 ms
720 ms
727 ms
737 ms

Avg: 732 ms.

This is almost double the vDSP version.

There is too large a difference in performance to switch to ffmpeg.

Powered by Google App Engine
This is Rietveld 408576698