Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc

Issue 2689203002: Check for some extensions before calling potentially NULL GL entry points. (Closed)
Patch Set: Revert discard_framebuffer functional change Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
index 742793d0a190fa8aa0db443b4d0e99801b0abbba..01838e344cd84d1e8614c535d3511ce4c2460799 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
@@ -4,6 +4,7 @@
#include "gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h"
+#include "base/strings/string_split.h"
#include "gpu/command_buffer/service/feature_info.h"
#include "gpu/command_buffer/service/gl_utils.h"
#include "ui/gl/gl_version_info.h"
@@ -173,7 +174,9 @@ bool GLES2DecoderPassthroughImpl::Initialize(
// Check for required extensions
if (!feature_info_->feature_flags().angle_robust_client_memory ||
- !feature_info_->feature_flags().chromium_bind_generates_resource) {
+ !feature_info_->feature_flags().chromium_bind_generates_resource ||
+ !feature_info_->feature_flags().chromium_copy_texture ||
+ !feature_info_->feature_flags().chromium_copy_compressed_texture) {
// TODO(geofflang): Verify that ANGLE_webgl_compatibility is enabled if this
// is a WebGL context (depends on crbug.com/671217).
Destroy(true);
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698