third_party/WebKit/Source/core/dom/ScriptLoader.cpp - Issue 2689173002: Implement script MIME restrictions for X-Content-Type-Options: nosniff for Workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

Issue 2689173002: Implement script MIME restrictions for X-Content-Type-Options: nosniff for Workers (Closed)

Patch Set: incorporated mkwst@'s comment Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/ScriptLoader.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

index 16c5e50d74c88c5fa276f2fe1e64983009b9733e..50498e1534f96ceec3bf953f249a08a64a8a168c 100644

--- a/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptLoader.cpp

@@ -480,7 +480,7 @@ bool ScriptLoader::doExecuteScript(const ScriptSourceCode& sourceCode) {

ScriptResource* resource =

m_resource ? m_resource.get() : sourceCode.resource();

if (resource) {

- if (!resource->mimeTypeAllowedByNosniff()) {

+ if (!ScriptResource::mimeTypeAllowedByNosniff(resource->response())) {

contextDocument->addConsoleMessage(ConsoleMessage::create(

SecurityMessageSource, ErrorMessageLevel,

"Refused to execute script from '" +